Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: rename fct_na_value_to_level etc to fct_na_to_level etc as more readable #353

Open
davidhodge931 opened this issue Aug 19, 2023 · 1 comment
Labels
feature a feature request or enhancement

Comments

@davidhodge931
Copy link

Great work on the new functions converting NAs to levels/values!

This is subjective, but I wonder if the functions would be better named in a more concise way for better human readability. As NA can only either be a value or a level, it makes sense to me that you don't need to specify what it is being changed from

So status quo:
fct_na_value_to_level
fct_na_level_to_value

Proposed:
fct_na_to_level
fct_na_to_value

@hadley
Copy link
Member

hadley commented Oct 31, 2023

Hmmm, interesting idea. Will definitely contemplate it next time I'm working on forcats!

@hadley hadley added the feature a feature request or enhancement label Oct 31, 2023
@davidhodge931 davidhodge931 changed the title Rename fct_na_value_to_level etc to fct_na_to_level etc as more readable Feature request: rename fct_na_value_to_level etc to fct_na_to_level etc as more readable Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants