Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing docs for S3 methods? #214

Open
hadley opened this issue Jul 25, 2024 · 9 comments
Open

Missing docs for S3 methods? #214

hadley opened this issue Jul 25, 2024 · 9 comments
Milestone

Comments

@hadley
Copy link
Member

hadley commented Jul 25, 2024

I think it would be useful to document mutate(), filter() etc methods so its obvious that duckplyr supports them. This would also be a good place to document any differences in behaviour.

@hadley hadley added this to the 1.0.0 milestone Sep 25, 2024
@krlmlr
Copy link
Member

krlmlr commented Oct 16, 2024

DoD:

  • Understand and perhaps avoid collisions that occur for ?mutate as soon as duckplyr is loaded
  • Draft for 2-3 verbs, reviewed
  • Documentation for verbs similarly to ?dbplyr::mutate.tbl_lazy
  • Fallback conditions are documented
  • Most important differences in behavior are documented
  • Add list of verbs that are not implemented

@maelle

This comment has been minimized.

@maelle

This comment has been minimized.

@maelle

This comment has been minimized.

@maelle

This comment has been minimized.

@maelle
Copy link
Collaborator

maelle commented Nov 21, 2024

methods("mutate") works but methods("select") suffers from the conflict.

@maelle
Copy link
Collaborator

maelle commented Nov 21, 2024

@krlmlr
Copy link
Member

krlmlr commented Nov 21, 2024

I don't follow:

options(conflicts.policy = list(warn = FALSE))
library(dplyr)

dplyr:::methods_generic("mutate")
#> # A tibble: 1 × 7
#>   generic class      package topic visible source              isS4 
#>   <chr>   <chr>      <chr>   <chr> <lgl>   <chr>               <lgl>
#> 1 mutate  data.frame dplyr   <NA>  FALSE   registered S3method FALSE
dplyr:::methods_generic("select")
#> # A tibble: 1 × 7
#>   generic class      package topic visible source              isS4 
#>   <chr>   <chr>      <chr>   <chr> <lgl>   <chr>               <lgl>
#> 1 select  data.frame dplyr   <NA>  FALSE   registered S3method FALSE

library(dbplyr)
library(dtplyr)
library(dm)

dplyr:::methods_generic("mutate")
#> # A tibble: 5 × 7
#>   generic class       package topic                    visible source      isS4 
#>   <chr>   <chr>       <chr>   <chr>                    <lgl>   <chr>       <lgl>
#> 1 mutate  data.frame  dplyr   <NA>                     FALSE   registered… FALSE
#> 2 mutate  dm          dm      <NA>                     FALSE   registered… FALSE
#> 3 mutate  dm_zoomed   dm      dplyr_table_manipulation FALSE   registered… FALSE
#> 4 mutate  dtplyr_step dtplyr  mutate.dtplyr_step       FALSE   registered… FALSE
#> 5 mutate  tbl_lazy    dbplyr  mutate.tbl_lazy          FALSE   registered… FALSE
dplyr:::methods_generic("select")
#> # A tibble: 5 × 7
#>   generic class       package topic                    visible source      isS4 
#>   <chr>   <chr>       <chr>   <chr>                    <lgl>   <chr>       <lgl>
#> 1 select  data.frame  dplyr   <NA>                     FALSE   registered… FALSE
#> 2 select  dm          dm      <NA>                     FALSE   registered… FALSE
#> 3 select  dm_zoomed   dm      dplyr_table_manipulation FALSE   registered… FALSE
#> 4 select  dtplyr_step dtplyr  select.dtplyr_step       FALSE   registered… FALSE
#> 5 select  tbl_lazy    dbplyr  select.tbl_lazy          FALSE   registered… FALSE

Created on 2024-11-21 with reprex v2.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants