Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - muliple joins fail in MS Access - expecting additional parenthesis ? #1576

Open
ovancantfort opened this issue Feb 3, 2025 · 0 comments

Comments

@ovancantfort
Copy link

Hello,

I noticed multiple successive joins fail in MS Access.
For example, using the industrial emission DB available at https://sdi.eea.europa.eu/data/ff47e25d-5d4c-491d-b9ce-de17ca61fe6d

library(DBI)
library(odbc)
library(tidyverse)
library(dbplyr)

odbcListDataSources()
con <- dbConnect(odbc::odbc(), 
                 DSN="EPRTR")

sites <- tbl(con, "1_ProductionSite") %>% 
  select(Site_INSPIRE_ID) 
  

facilities <- tbl(con, "2_ProductionFacility") %>% 
  select(Parent_Site_INSPIRE_ID, Facility_INSPIRE_ID )

installations <- tbl(con, "3_ProductionInstallation") %>%
  select(Parent_Facility_INSPIRE_ID, Installation_INSPIRE_ID) 

join <- facilities %>%
  left_join(y= installations, by=c("Facility_INSPIRE_ID"="Parent_Facility_INSPIRE_ID") )%>% 
  left_join(y=sites, by=c("Parent_Site_INSPIRE_ID"="Site_INSPIRE_ID") )

 join %>% show_query()

We get the query

SELECT
  `Parent_Site_INSPIRE_ID`,
  `Facility_INSPIRE_ID`,
  `Installation_INSPIRE_ID`
FROM `2_ProductionFacility`
LEFT JOIN `3_ProductionInstallation`
  ON (`2_ProductionFacility`.`Facility_INSPIRE_ID` = `3_ProductionInstallation`.`Parent_Facility_INSPIRE_ID`)
LEFT JOIN `1_ProductionSite`
  ON (`2_ProductionFacility`.`Parent_Site_INSPIRE_ID` = `1_ProductionSite`.`Site_INSPIRE_ID`)

This query fails in Access with the message:

Syntax error (missing operator) in query expression '(`2_ProductionFacility`.`Facility_INSPIRE_ID` =
  `3_ProductionInstallation`.`Parent_Facility_INSPIRE_ID`)

However, similar queries generated by Access have parenthesis around the first join. Adding parenthesis to the query generated by dplyr and copy/paste to Access allows the query to run successfully.

SELECT
  `Parent_Site_INSPIRE_ID`,
  `Facility_INSPIRE_ID`,
  `Installation_INSPIRE_ID`
FROM (
`2_ProductionFacility`
LEFT JOIN `3_ProductionInstallation`
  ON (`2_ProductionFacility`.`Facility_INSPIRE_ID` = `3_ProductionInstallation`.`Parent_Facility_INSPIRE_ID`)
)
LEFT JOIN `1_ProductionSite`
  ON (`2_ProductionFacility`.`Parent_Site_INSPIRE_ID` = `1_ProductionSite`.`Site_INSPIRE_ID`)

dbplyr version 2.5.0
dplyr version 1.1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant