Skip to content

Commit

Permalink
Release to 0.5.0 (#339)
Browse files Browse the repository at this point in the history
* Bump Release to 0.5.0 
* Update Documentation
  • Loading branch information
thsmi authored Aug 8, 2020
1 parent 96c86b8 commit e20f4ae
Show file tree
Hide file tree
Showing 7 changed files with 37 additions and 21 deletions.
21 changes: 15 additions & 6 deletions FAQ.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,19 @@ In case the language is [not supported by the webextension](https://crowdin.com/

Thunderbird's default language can be changed in the "Options" select there "Advanced" and locate the "Language" dropdown. Setting languages is only possible on official Thunderbird releases. Nightly version support only en-US.

## WebExtension: How to install a side loaded WebExtension

Currently the review process for addons.thunderbird.net is extremely slow. It takes several
month until an update is listed. Thus you may want to install the addon directly from this repository.

Download the latest release from the [releases section](https://github.com/thsmi/sieve/releases).

If you are a Firefox user, you need to right click on the "Thunderbird WebExtension" link and select "Save Link As" otherwise Firefox tries to install the WebExtension into your browser and ends with an error message.

In Thunderbird you need to open the add-on manager. Either via the burger menu or via the main menu bar (Tools -> Add-ons). Then just drag the downloaded xpi file into the add-on Manager. You can also select the gear icon in the add-on manager and select "Install add-on from file" as illustrated below.

![image](https://user-images.githubusercontent.com/53547181/84571294-61f2f700-ad60-11ea-94b9-71fe94db739e.png)

## WebExtension: How to start

The menu items to open the editor is directly adjacent to the builtin message filters.
Expand All @@ -29,9 +42,7 @@ Which means in the main menu it is located in "Tools -> Sieve Message Filters" w

Occasionally Linux users get confused about the line breaks in sieve script.

Sieve, like in almost all other internet protocols (http, imap, ...), uses a two
character newline sequence CRLF. This sequence dates back to DEC and is also
used on Windows. Unix/Linux use a single LF mostly due to historic reasons.
Sieve, like in almost all other internet protocols (http, imap, ...), uses a two character newline sequence CRLF. This sequence dates back to DEC and is also used on Windows. Unix/Linux use a single LF mostly due to historic reasons.

[RFC5228](https://tools.ietf.org/html/rfc5228) defines:

Expand All @@ -55,6 +66,4 @@ used on Windows. Unix/Linux use a single LF mostly due to historic reasons.
```

As you can see, using single newlines is illegal syntax in sieve scripts and
has to be rejected by the server. Thus exported scripts may look strange if you
open them in a text editor on macOS or Linux. This is not a bug.
Using single newlines is illegal syntax in sieve scripts and has to be rejected by the server. Thus exported scripts may look strange if you open them in a text editor on macOS or Linux. This is not a bug.
8 changes: 8 additions & 0 deletions docs/update.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@
"addons": {
"[email protected]": {
"updates": [
{
"version": "0.5.0",
"update_link": "https://github.com/thsmi/sieve/releases/download/0.5.0/sieve-0.5.0.xpi",
"update_info_url": "https://github.com/thsmi/sieve/releases/tag/0.5.0",
"browser_specific_settings": {
"gecko": { "strict_min_version": "68.0a1" }
}
},
{
"version": "0.4.2",
"update_link": "https://github.com/thsmi/sieve/releases/download/0.4.2/sieve-0.4.2.xpi",
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "sieve",
"version": "0.4.2",
"version": "0.5.0",
"description": "Configures server-side sieve email filters",
"directories": {
"doc": "docs",
Expand Down Expand Up @@ -38,4 +38,4 @@
"url": "https://github.com/thsmi/sieve/issues"
},
"homepage": "https://github.com/thsmi/sieve#readme"
}
}
3 changes: 1 addition & 2 deletions src/app/libs/managesieve.ui/accounts/account.settings.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@
<div style="min-width:8em" data-i18n="account.details.server"></div>
<span class="sieve-settings-hostname"></span>:
<span class="sieve-settings-port"></span>
&nbsp;
<span class="sieve-settings-secure" data-i18n="account.details.secure"></span>
<span class="sieve-settings-secure ml-1" data-i18n="account.details.secure"></span>
</div>
<div class="sieve-settings-fingerprint-item d-none">
<div class="d-flex flex-row form-label ">
Expand Down
16 changes: 8 additions & 8 deletions src/wx/libs/managesieve.ui/accounts/account.settings.tpl
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
<div>
<h4 data-i18n="account.details.title"></h4>
<div class="row">
<span class="col-3" data-i18n="account.details.server"></span>
<span class="sieve-settings-hostname"></span>:
<span class="sieve-settings-port"></span>
<span class="sieve-settings-secure ml-1" data-i18n="account.details.secure"></span>
<div class="d-flex flex-row form-label">
<div style="min-width:8em" data-i18n="account.details.server"></div>
<span class="sieve-settings-hostname"></span>:
<span class="sieve-settings-port"></span>
<span class="sieve-settings-secure ml-1" data-i18n="account.details.secure"></span>
</div>
<!--<div class="row sieve-settings-fingerprint-item">
<span class="col-3">Fingerprint:</span>
<span class="sieve-settings-fingerprint"></span>
</div>-->
<div class="row">
<span class="col-3" data-i18n="account.details.username"></span>
<span class="sieve-settings-username"></span>
<div class="d-flex flex-row form-label ">
<div style="min-width:8em" data-i18n="account.details.username"></div>
<div class="sieve-settings-username"></div>
</div>
<!--<div class="row">
<span class="col-3">SASL Mechanism:</span>
Expand Down
2 changes: 1 addition & 1 deletion src/wx/manifest.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "Sieve",
"description": "Manages Sieve Message Filters",
"version": "0.4.2",
"version": "0.5.0",
"icons": {
"64": "libs/icons/linux.png"
},
Expand Down
4 changes: 2 additions & 2 deletions tests/js/node/NodeTestSuite.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@
*/
async init(report, scripts) {

const program = path.resolve(`${__dirname}/Sandbox/Sandbox.mjs`);
const program = path.resolve(`${__dirname}/sandbox/Sandbox.mjs`);

if (!fs.existsSync(program))
throw new Error("Could not find sandbox");
throw new Error(`Could not find sandbox ${program}`);

const args = [];

Expand Down

0 comments on commit e20f4ae

Please sign in to comment.