Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requiring --skip_rubocop in command line parameters causes script failure when Rails < 7.2 #1233

Open
louis-antonopoulos opened this issue Oct 25, 2024 · 3 comments · May be fixed by #1237
Open

Comments

@louis-antonopoulos
Copy link
Contributor

The web.rb script fails when running versions of Rails before 7.2 because --skip_rubocop is not a valid option, and so it is not parsed.

#1223 added a requirement to specify the --skip_rubocop parameter to resolve #1221.

@louis-antonopoulos
Copy link
Contributor Author

(identified while pairing with @stevepolitodesign)

@stevepolitodesign
Copy link
Contributor

I think we have a few options here:

  • We could update the README by encouraging users to use the latest version of Rails.
  • We could return early in the application template if the detected version is below 7.2

@louis-antonopoulos
Copy link
Contributor Author

I'm going to be opening a PR to return early as you suggest!

@louis-antonopoulos louis-antonopoulos linked a pull request Oct 31, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants