Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do we want to handle Ruby linting now that Rails ships with a solution? #1214

Open
stevepolitodesign opened this issue Jun 18, 2024 · 3 comments
Labels
Discussion Needs feedback

Comments

@stevepolitodesign
Copy link
Contributor

Rails 7.2 now ships with rubocop-rails-omakase.

However, with the introduction of #1148, we risk having two linting mechanisms.

@stevepolitodesign stevepolitodesign added the Discussion Needs feedback label Jun 18, 2024
@stevepolitodesign
Copy link
Contributor Author

@DoodlingDev
Copy link
Contributor

From the notes about this change--

If you or your team has developed a particular house style that brings you joy, you should cherish that.

standardrb and standard-rails work well, we're accustomed to them, migrating away from tbot preferences (even if it's Rails standard now) feels like the antithesis of suspenders.

Should we move to omakase as our recommended and most-oft-used system, then maybe we change suspenders?

@stevepolitodesign
Copy link
Contributor Author

@DoodlingDev

If you or your team has developed a particular house style that brings you joy, you should cherish that.

Ha! I didn't even see that. That makes me feel good about the changes introduced in #1223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Needs feedback
Projects
None yet
Development

No branches or pull requests

2 participants