Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Ruby 3.0 #1715

Open
sarahraqueld opened this issue Nov 6, 2024 · 2 comments
Open

Drop support for Ruby 3.0 #1715

sarahraqueld opened this issue Nov 6, 2024 · 2 comments

Comments

@sarahraqueld
Copy link
Contributor

sarahraqueld commented Nov 6, 2024

Ruby 3.0 reached EOL on April 2024, but we're still running that version on CI:

Screenshot 2024-11-06 at 11 10 44

Editing the workflow build file to remove 3.0 should be enough to close this issue: https://github.com/thoughtbot/factory_bot/blob/main/.github/workflows/build.yml

@CodeMeister
Copy link
Contributor

If Ruby 3.0 is working with Rails 7.0 and 7.1 then it looks like it's the gem resolution with Rails 6.1 is the issue.

I'm hesitant for 3.0 to be removed as there are still smaller companies using this version. (yes, they should really upgrade, but many don't have the budget available)

A simpler resolution to stop the automated tests failing would be to exclude Rails 6.1 when testing Ruby 3.0.

However, if FactoryBot now needs gems that don't run on 3.0 then I would suggest bumping the major version number, so Ruby 3.0 developers will know not jump versions.

@neilvcarvalho
Copy link
Member

Yep, I think we can support 3.0 (in general, one or two EOL versions?) until it becomes too hard to do so. The Ruby 3.0 / 6.1 issue was solved, and was happening because we were wrongly saving the Appraisals generated Gemfile.lock files, which led to impossible gem resolutions for this Ruby/Rails combination (that is valid, by the way).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants