Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExcludeProperties DumpOption doesn't include fields #51

Open
CaptainDapper opened this issue Feb 24, 2020 · 1 comment
Open

ExcludeProperties DumpOption doesn't include fields #51

CaptainDapper opened this issue Feb 24, 2020 · 1 comment

Comments

@CaptainDapper
Copy link

It's unintuitive, although it's named properly. I had expected my ExcludeProperties list to remove any fields with the same name as well as properties with the name.

I would suggest renaming ExcludeProperties to simply "Exclude" and removing any member at all from the output. Or, add an ExcludeFields option but that seems redundant, though it's the easy/lazy choice.

@thomasgalliker
Copy link
Owner

I would also prefere the Exclude way but I’m 100% convinced that many people would like to have separated exclude options (for fields and for properties). What about this:

  • Exclude (for fields and properties, and ???)
  • ExcludeProperties
  • ExcludeFields

🧐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants