Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-v2.10] drivers: dma: intel_adsp_hda: change L1 exit defaults #79

Merged

Conversation

kv2019i
Copy link
Collaborator

@kv2019i kv2019i commented Jun 19, 2024

DMA_INTEL_ADSP_HDA_TIMING_L1_EXIT should be set by default for both Intel ACE15 and ACE20 platforms.

Signed-off-by: Kai Vehmanen [email protected]
(cherry picked from commit a4fdd91)

DMA_INTEL_ADSP_HDA_TIMING_L1_EXIT should be set by default
for both Intel ACE15 and ACE20 platforms.

Signed-off-by: Kai Vehmanen <[email protected]>
(cherry picked from commit a4fdd91)
@kv2019i kv2019i requested a review from abonislawski as a code owner June 19, 2024 18:36
Copy link

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait: a4fdd91

This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Considering how convoluted this L1 situation has been[*], the commit message definitely deserves the correct SHA1

[*] thesofproject/sof#9194 etc.

@kv2019i
Copy link
Collaborator Author

kv2019i commented Jun 20, 2024

@marc-hb the SHA1 is the correct one merged to upstream Zephyr:

The warning was emitted as nobody had pushed Zephyr main to the SOF fork project. I now did that to silence the warning.

Ok to merge?

@kv2019i
Copy link
Collaborator Author

kv2019i commented Jun 20, 2024

I've double/triple checked this now, so @marc-hb I'll take the risk and ignore your -1 so I can proceed with rc1 preps during my workday today.

@kv2019i kv2019i dismissed marc-hb’s stale review June 20, 2024 08:13

SHA1 is confirmed to match the one in Zephyr upstream main branch

@kv2019i kv2019i merged commit 0f7a01d into thesofproject:sof/stable-v2.10 Jun 20, 2024
11 of 12 checks passed
@marc-hb
Copy link

marc-hb commented Jun 20, 2024

The warning was emitted as nobody had pushed Zephyr main to the SOF fork project. I now did that to silence the warning.

My bad, I didn't try hard to enough to find this commit. Sorry for the noise. Well done ignoring my -1, apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants