Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Discord link is invalid #7161

Closed
mbana opened this issue Feb 22, 2023 · 6 comments
Closed

[BUG] Discord link is invalid #7161

mbana opened this issue Feb 22, 2023 · 6 comments
Assignees
@marc-hb
Labels
bug Something isn't working as expected

Comments

@mbana
Copy link

mbana commented Feb 22, 2023

The channel linked to in the README.md is invalid:

[#sof channel on discord.com](https://discord.com/channels/720317445772017664/930855494472589362)
@mbana mbana added the bug Something isn't working as expected label Feb 22, 2023
@lgirdwood
Copy link
Member

@marc-hb fyi

@marc-hb
Copy link
Collaborator

marc-hb commented Mar 2, 2023

Is the link asking you to login?

@marc-hb marc-hb closed this as completed Mar 9, 2023
@DaveLak
Copy link
Contributor

DaveLak commented Nov 27, 2024

FWIW it's still a broken link. When I click it on a browser where I'm already logged in I just get an empty Discord page (see Screenshot in the foldout below.) I think you need a proper invite link if you want to allow users to joing. The format is something like: https://discord.gg/<$INVITE_CODE>

Screenshot image

@marc-hb
Copy link
Collaborator

marc-hb commented Nov 28, 2024 •
edited
Loading

Thanks @DaveLak . Can you submit a pull request replacing this link with a link to https://github.com/zephyrproject-rtos and a short sentence? This #sof channel is part of the Zephyr area (another gap in the README.md), so no point duplicating the Zephyr INVITE process/code/documentation here in SOF.

@marc-hb marc-hb reopened this Nov 28, 2024
@DaveLak
Copy link
Contributor

DaveLak commented Nov 28, 2024

Thanks @DaveLak . Can you submit a pull request replacing this link with a link to https://github.com/zephyrproject-rtos and a short sentence? This #sof channel is part of the Zephyr area (another gap in the README.md), so no point duplicating the INVITE process/code/documentation here.

Yes, I'd be happy to. Thanks for the context!

DaveLak added a commit to DaveLak/sof that referenced this issue Jan 3, 2025
@DaveLak
Replace Invalid Discord Link in README.md
455f50c 
Fixes the broken Discord link discussed in issue thesofproject#7161.

The `#sof` Discord channel is part of the Zephyr ecosystem so we refer to that project's invite instructions and community documentation.

See: thesofproject#7161

Signed-off-by: David Lakin <[email protected]>
@DaveLak DaveLak mentioned this issue Jan 3, 2025
Merged
@DaveLak
Copy link
Contributor

DaveLak commented Jan 3, 2025

@marc-hb PR with the README changes as requested: #9762

DaveLak added a commit to DaveLak/sof that referenced this issue Jan 10, 2025
@DaveLak
README.md: update Discord channel instructions
228788b 
Replace the direct #sof Discord channel link with a reference to the
Zephyr project's documentation for accessing their server, where the
channel is hosted.

The previous link only worked for users already in the Zephyr Discord
server, potentially confusing new visitors looking to join the channel.

Pointing to Zephyr's community docs provides the necessary context and
instructions for getting an invite to access the #sof channel.

Since the channel is part of Zephyr’s Discord server, directing readers
to their official documentation ensures the instructions remain accurate
while sparing this project from duplicating details.

Fixes GitHub issue thesofproject#7161.

Signed-off-by: David Lakin <[email protected]>
lgirdwood pushed a commit that referenced this issue Jan 13, 2025
@DaveLak @lgirdwood
README.md: update Discord channel instructions
0a3dcdf 
Replace the direct #sof Discord channel link with a reference to the
Zephyr project's documentation for accessing their server, where the
channel is hosted.

The previous link only worked for users already in the Zephyr Discord
server, potentially confusing new visitors looking to join the channel.

Pointing to Zephyr's community docs provides the necessary context and
instructions for getting an invite to access the #sof channel.

Since the channel is part of Zephyr’s Discord server, directing readers
to their official documentation ensures the instructions remain accurate
while sparing this project from duplicating details.

Fixes GitHub issue #7161.

Signed-off-by: David Lakin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marc-hb marc-hb

Labels
bug Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mbana @lgirdwood @DaveLak @marc-hb