[RFC] rimage: Add support for multiple toml file #176
Conversation
This patch adds support for multiple toml configuration file. Signed-off-by: Chao Song <[email protected]>
|
The toml lib we use can not support toml merging, we need to merge multiple files together before parsing. This RFC used a function |
|
@kv2019i @lgirdwood refering to thesofproject/sof#7270 and this RFC, could you please comment? |
| buf[file_size[i]] = '\n'; | ||
| buf += file_size[i] + 1; | ||
| } | ||
| return fmemopen(files->buffer, buf_size, mode); |
There was a problem hiding this comment.
Ok this is quite clever approach. "fmemopen()" will potentially hit some compatibility issues, so needs a smoketest on Windows at minimum.
I was actually thinking of something much more low-tech. I.e. "cat a.toml b.toml >$BUILD/rimage.toml" in make rules, and pass generated "rimage.toml" to rimage. But making this in a portable way is not zero effort either, so I guess depends in the end what is the lowest effort way to make this so that it works across platforms.
There was a problem hiding this comment.
A new proposal, see #179, this probably won't work on windows, let's close
Windows has https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/mktemp-s-wmktemp-s?view=msvc-170 |
This patch adds support for multiple toml
configuration file.