Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We're not catching the Error: Bitcoin account was not connected. error #595

Open
michalinacienciala opened this issue Jul 11, 2024 · 3 comments
Labels
🐛 Bug Something isn't working 🎨 dApp dApp 🍊OrangeKit

Comments

@michalinacienciala
Copy link
Contributor

michalinacienciala commented Jul 11, 2024

Steps to reproduce (maybe there are also other that can lead to the same error?):

  1. Connect to dapp with some wallet extension with tha account that has at least 0.015 BTC.
  2. Go to the deposit form
  3. Turn off the wallet extension
  4. Choose to deposit at least 0.015 BTC. Confirm and observe

Result:
Dapp shows the Waiting transaction view even though there is a Bitcoin account was not connected error in the console:

image

I think it would be good to show some error here to the user.

@michalinacienciala michalinacienciala added 🐛 Bug Something isn't working 🎨 dApp dApp labels Jul 11, 2024
@kkosiorowska kkosiorowska self-assigned this Jul 17, 2024
@kkosiorowska
Copy link
Contributor

@SorinQ What should we do in that case? Michalina suggests some kind of message. However, it should be noted that if the user disables the extension or removes it, we should probably disconnect the user.

@SorinQ
Copy link
Collaborator

SorinQ commented Jul 17, 2024

I agree we should disconnect the user for now. I think this is a super edgecase scenario. @kkosiorowska

@michalinacienciala
Copy link
Contributor Author

If disconnecting the user is technically feasible, I agree, that's what we should do.

@kkosiorowska kkosiorowska removed their assignment Nov 29, 2024
@nkuba nkuba added the 🍊OrangeKit label Dec 9, 2024 — with Linear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working 🎨 dApp dApp 🍊OrangeKit
Projects
None yet
Development

No branches or pull requests

4 participants