Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration within Box #112

Open
theofidry opened this issue Nov 4, 2023 · 7 comments
Open

Integration within Box #112

theofidry opened this issue Nov 4, 2023 · 7 comments

Comments

@theofidry
Copy link

Hi! As you know I maintain https://github.com/box-project/box and I would like to somehow integrate Autoload into it (or at least part of it).

The rationale being there is one feature which I think is really missing within Box and that is ditching the Composer autoloader. In general having the Composer autoloader is not so much of an issue, but I have cases, for example the RequirementChecker where it forces the code to require PHP 7.2+ where I the original code could be PHP 5.6.

I had a quick look but I admit I'm not entirely sure on how to proceed. I at first was thinking of either requiring the project itself, but then there is a lot of "extra" that doesn't really make sense to include within Box. Another way would be to copy/paste the relevant code whilst keeping the license (like it was done with the requirement checker that was Symfony's code for the most part). But overall I see a lot of features where I am not really sure I understand the intent itself...

Hence this issue. Do you have any pointers/thoughts? Or are you against the idea?

@theseer
Copy link
Owner

theseer commented Nov 4, 2023

I actually love to have us cooperate :)

I agree that the codebase is not exactly in a state where requiring it as a library seems useful.

I'm also no longer convinced that having all the phar building stuff included actually makes sense, given that box probably does a better job at doing it and it deviated the project from "simply" being an autoload map generator.

We should find some time to discuss options - either virtually or in person.

@theofidry
Copy link
Author

We should find some time to discuss options - either virtually or in person.

Would love too, unless you're at the SfCon probably best doing a Discord call?

@theseer
Copy link
Owner

theseer commented Nov 4, 2023

I'm not really using Discord, but we can use my whereby room at any time.
Any general time frame?

@theofidry
Copy link
Author

I would say week day at 12:00 or any time after 18:00

@theofidry
Copy link
Author

Any chance this or next week? Given you have a more busy schedule than I, I think I can accommodate more easily :)

@theseer
Copy link
Owner

theseer commented Dec 11, 2023

sigh You're we just need to fix a date. :)

Evenings are hard for me to fit into my life, but over lunch should work.
How about Friday, 12:00?

@theofidry
Copy link
Author

good for me. If it's easier during the day it's fine by me too tbh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants