Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion and adoption of ST-tabbyAPI-loader into ST codebase #8

Open
Dakraid opened this issue Mar 18, 2024 · 2 comments
Open

Completion and adoption of ST-tabbyAPI-loader into ST codebase #8

Dakraid opened this issue Mar 18, 2024 · 2 comments

Comments

@Dakraid
Copy link

Dakraid commented Mar 18, 2024

Greetings,
so I've recently started an effort to integrate model swapping into SillyTavern directly before I was made aware of this extension. Given I've only added the model swapping at this point, it isn't as feature-complete as this extension.

To avoid doing duplicate work, I would like to propose that I finish the extension while adding its code to the main ST code. Would this be appreciated, and if so are there certain wishes or points that I should respect?

With kind regards,
Kris

@kingbri1
Copy link
Member

Yes, the point of the extension is to eventually integrate it into SillyTavern. I've been in discussion with @Cohee1207 and would like to get the ball rolling.

The extension is pretty much complete apart from lora selection and scaling parameters. So, I think it's ok to port over to ST staging in its current state. Can you please forward the work you've done and we can get started!

Also, feel free to ping me @kingbri on discord in ST's server or tabby's support server. It should be easier to discuss things there.

@Dakraid
Copy link
Author

Dakraid commented Mar 19, 2024

Sorry for the late response, I wasn't feeling well. Most of the work so far is here: https://github.com/Dakraid/SillyTavern/tree/feature/tabbyapi-switch-models

Cohee has already given me some pointers on how to improve things, and once that is done I'm going to add the admin key check and adopt the rest of the extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants