Set Cache-Control header when writing to disk

[martinbean]

I’m using Glide to generate thumbnails, which are stored on S3 and then served via CloudFront. When Glide stores the image in S3, it doesn’t set a Cache-Control header, so CloudFront always serves thumbnails with no-cache.

Could Glide set the Cache-Control header when writing images to the “cache” disk? It seems the write() method call at…

glide/src/Server.php

Lines 526 to 529 in b976168

	$write = $this->cache->write(
	$cachedPath,
	$this->api->run($tmp, $this->getAllParams($params))
	);

…would need to pass the Cache-Control header as the third parameter so that it’s set against the image when being written to S3. This would then allow CloudFront to serve 304 Not Modified responses.

Example:

$write = $this->cache->write(
    $cachedPath,
    $this->api->run($tmp, $this->getAllParams($params)),
    ['Cache-Control' => 'public, max-age=31536000']
);

The Cache-Control header is added to thumbnails, but only in the outputImage() method and after the thumbnails file has been stored.