Support json.Number values, more docs

Author: theory

spec/filter.go

@@ -26,7 +26,10 @@ type BasicExpr interface {
 // LogicalAnd represents a list of one or more expressions ANDed together by
 // the && operator. Evaluates to true if all of its expressions evaluate to
 // true. Short-circuits and returns false for the first expression that
-// returns false. Implements [BasicExpr] and [fmt.Stringer].
+// returns false. Interfaces implemented:
+//
+//   - [BasicExpr]
+//   - [fmt.Stringer]
 type LogicalAnd []BasicExpr
 
 // And creates a LogicalAnd of all expr.
@@ -122,19 +125,17 @@ func (lo LogicalOr) ResultType() FuncType {
 }
 
 // ParenExpr represents a parenthesized expression that groups the elements of
-// a [LogicalOr].
-//
-// Interfaces implemented (via the underlying [LogicalOr]):
+// a [LogicalOr]. Interfaces implemented (via the underlying [LogicalOr]):
 //   - [BasicExpr]
 //   - [FuncExprArg]
 //   - [fmt.Stringer]
 type ParenExpr struct {
 	LogicalOr
 }
 
-// Paren returns a new ParenExpr that ORs each and.
-func Paren(and ...LogicalAnd) *ParenExpr {
-	return &ParenExpr{LogicalOr: LogicalOr(and)}
+// Paren returns a new ParenExpr that ORs the results of each expr.
+func Paren(expr ...LogicalAnd) *ParenExpr {
+	return &ParenExpr{LogicalOr: LogicalOr(expr)}
 }
 
 // writeTo writes a string representation of p to buf. Defined by
@@ -153,7 +154,7 @@ func (p *ParenExpr) String() string {
 }
 
 // NotParenExpr represents a negated parenthesized expression that groups the
-// elements of a [LogicalOr] Interfaces implemented (via the underlying
+// elements of a [LogicalOr]. Interfaces implemented (via the underlying
 // [LogicalOr]):
 //   - [BasicExpr]
 //   - [FuncExprArg]
@@ -162,9 +163,9 @@ type NotParenExpr struct {
 	LogicalOr
 }
 
-// NotParen returns a new NotParenExpr that ORs each and.
-func NotParen(and ...LogicalAnd) *NotParenExpr {
-	return &NotParenExpr{LogicalOr: LogicalOr(and)}
+// NotParen returns a new NotParenExpr that ORs each expr.
+func NotParen(expr ...LogicalAnd) *NotParenExpr {
+	return &NotParenExpr{LogicalOr: LogicalOr(expr)}
 }
 
 // writeTo writes a string representation of p to buf. Defined by
@@ -198,7 +199,7 @@ type ExistExpr struct {
 	*PathQuery
 }
 
-// Existence creates a new [ExistExpr].
+// Existence creates a new [ExistExpr] for q.
 func Existence(q *PathQuery) *ExistExpr {
 	return &ExistExpr{PathQuery: q}
 }
@@ -225,7 +226,7 @@ type NonExistExpr struct {
 	*PathQuery
 }
 
-// Nonexistence creates a new [NonExistExpr].
+// Nonexistence creates a new [NonExistExpr] for q.
 func Nonexistence(q *PathQuery) *NonExistExpr {
 	return &NonExistExpr{PathQuery: q}
 }