Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External IIIF images are not showing up in object grid #984

Open
1 task done
Erin-Cecele opened this issue Dec 13, 2024 · 0 comments
Open
1 task done

External IIIF images are not showing up in object grid #984

Erin-Cecele opened this issue Dec 13, 2024 · 0 comments
Assignees
Labels
status:triage needed Issue needs to be triaged by the Quire team. This label is automatically applied to new issues.

Comments

@Erin-Cecele
Copy link
Collaborator

Erin-Cecele commented Dec 13, 2024

Before proceeding, make sure there isn’t an existing issue for this bug.

  • I have searched the existing issues and determined this is a new bug.

Expected Behavior

The following figures.yaml entry featuring extgernal IIIF images should result in the image appearing in the catalogue object grid.

id: "cat-11"
src: cats/cat-11-ILE2006-4-163ag-obj-111215-0001-pub_2000.jpg
printImage: _assets/images/cats/cat-11-ILE2006-4-163ag-obj-111215-0001-pub_2000.jpg
manifestId: https://manifests.collections.yale.edu/yuag/obj/111215
canvasId: https://manifests.collections.yale.edu/canvas/yuag/0b9de3ff-5a63-44ef-89ba-178bfa068f47
zoom: true

Actual Behavior

Images that include manifestId and canvasId are not showing up in the object grid. They only show up if those two values are removed from the YAML or if they are replaced with non-external IIIF images.

Steps to Reproduce

Start a new project and include external IIIF images.

Version Numbers

[indonesian-textiles]
quire-cli 1.0.0-rc.11
quire-11ty 1.0.0-rc.16
starter https://github.com/thegetty/[email protected]
[System]
quire-cli 1.0.0-rc.15
node v18.20.4
npm 10.7.0
os Darwin 23.6.0

Web Browser

N/A

Relevant Terminal/Shell Output

N/A

Supporting Information

This issue was reported by @zsofiaj in discussion #959 and is affecting a current Yale project. We have offered a temporary workaround:

in

_includes/components/object-filters/object-card/object-image.webc

replace

const thumbnail = figures
  ? figures.find(({ mediaType }) => mediaType === 'image').thumbnail
  : data.thumbnail

with

let thumbnail
if (figures) {
  thumbnail = figures.find(({ mediaType }) => mediaType === 'image').manifestId
    ? figures.find(({ mediaType }) => mediaType === 'image').src
    : figures.find(({ mediaType }) => mediaType === 'image').thumbnail
} else {
  thumbnail = data.thumbnail
}
@Erin-Cecele Erin-Cecele added the status:triage needed Issue needs to be triaged by the Quire team. This label is automatically applied to new issues. label Dec 13, 2024
@Erin-Cecele Erin-Cecele self-assigned this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:triage needed Issue needs to be triaged by the Quire team. This label is automatically applied to new issues.
Projects
None yet
Development

No branches or pull requests

1 participant