Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asterisks appearing instead of italics in browser page title #929

Open
1 task done
zsofiaj opened this issue May 7, 2024 · 3 comments
Open
1 task done

Asterisks appearing instead of italics in browser page title #929

zsofiaj opened this issue May 7, 2024 · 3 comments
Assignees
Labels
status:triage needed Issue needs to be triaged by the Quire team. This label is automatically applied to new issues.

Comments

@zsofiaj
Copy link
Collaborator

zsofiaj commented May 7, 2024

Before proceeding, make sure there isn’t an existing issue for this bug.

  • I have searched the existing issues and determined this is a new bug.

Expected Behavior

In the browser page title, I expect italicized text, such as titles of works, to appear in italics.

Actual Behavior

Text that should be italicized, such as titles of works, appears with asterisks in the page title at the top of the browser, above the url.
Screenshot 2024-04-25 at 1 54 32 PM

Steps to Reproduce

Step 1: Go to any catalogue entry in our project, for example:
https://italian-paintings-live.netlify.app/catalogue/volume-1/other-tuscan-schools/71/

Step 2: At the top of the browser window, above the url, the page title should show the title of the object in italics, but it shows up with asterisks. This might only be visible if you open a fresh window, with only a single tab.

Version Numbers

Project:
quire-cli 1.0.0-rc.11
quire-11ty 1.0.0-rc.16
starter https://github.com/thegetty/[email protected]
System:
quire-cli 1.0.0-rc.11
node v20.4.0
npm 9.7.2
os Darwin 23.3.0

Web Browser

Safari 17.3
Chrome 124.0.6367.62

Relevant Terminal/Shell Output

No response

Supporting Information

No response

@zsofiaj zsofiaj added the status:triage needed Issue needs to be triaged by the Quire team. This label is automatically applied to new issues. label May 7, 2024
@its-leofisher
Copy link

@zsofiaj It's not possible to modify the text in the title bar of a browser. The browser tab title is controlled by the browser itself, and there is no standard HTML or CSS way to alter the font style (e.g., making it italic) of the tab title directly from a webpage. This is a security and consistency feature to ensure that browser interfaces remain uniform and predictable for users.

What I do suggest is to detect asteriks in the context of trying to italicize the text in between <title> and remove it.

@zsofiaj
Copy link
Collaborator Author

zsofiaj commented Jul 16, 2024

Thanks so much, @its-leofisher . I don't fully understand the suggestion in the last sentence of your post above. Are you saying I should remove the asterisks from the "title" field at the top of the md file for each object entry? I suppose the problem is that the original template was designed to display just a title as the page title for each entry, but we need it to display the artist and title, so we've formatted the title in italics. If I remove the asterisks, then the title will not appear italicized at the top of the entry, and we want it to be italicized there (where I've circled in the screenshot below). I hope that makes sense.

Screenshot 2024-07-16 at 2 47 26 PM

@its-leofisher
Copy link

its-leofisher commented Jul 16, 2024

Thanks so much, @its-leofisher . I don't fully understand the suggestion in the last sentence of your post above. Are you saying I should remove the asterisks from the "title" field at the top of the md file for each object entry? I suppose the problem is that the original template was designed to display just a title as the page title for each entry, but we need it to display the artist and title, so we've formatted the title in italics. If I remove the asterisks, then the title will not appear italicized at the top of the entry, and we want it to be italicized there (where I've circled in the screenshot below). I hope that makes sense.

Screenshot 2024-07-16 at 2 47 26 PM

I see, that makes sense. My suggestion to remove asteriks from the browser title bar is because they are unnecessary in context of SEO especially if the title can be long.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:triage needed Issue needs to be triaged by the Quire team. This label is automatically applied to new issues.
Projects
None yet
Development

No branches or pull requests

3 participants