Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{% contributors context=publicationContributors %} is causing contributors created with first_name last_name in page YAML to be overwritten #853

Open
1 task done
Erin-Cecele opened this issue Oct 6, 2023 · 2 comments
Assignees
Labels
bug Actual behavior does not match expected behavior quire-11ty This is an issue with the quire-11ty package status:backlog Issue is a lower priority but needs to eventually be addressed

Comments

@Erin-Cecele
Copy link
Collaborator

Before proceeding, make sure there isn’t an existing issue for this bug.

  • I have searched the existing issues and determined this is a new bug.

Expected Behavior

When using the {% contributors %} shortcode with context=publicationContributors all the contributors mentioned in page YAML and publication.yaml should be listed on the page with the shortcode. Under each contributor it should list the essays written by each contributor.

Actual Behavior

When using the {% contributors %} shortcode with context=publicationContributors the shortcode is looking for contributors listed in publication.yaml as well as any listed in the page YAML of individual markdown pages. But for those listed in page YAML, the data for each one is overriding the last, except for the links to papers. So, you end up with the info of the last contributor to be listed in the book, but with a list of every paper that all the other overridden contributors were part of.

Steps to Reproduce

  1. Create a new project
  2. Add two different contributors to the page YAML of two different .md files using the first_name and last_name fields.
  3. Look at the Contributors page of project and you will see only one of the two contributors listed and both essays listed under that one contributor

Version Numbers

[Project]
quire-cli 1.0.0-rc.10
quire-11ty 1.0.0-rc.14
starter /Users/edunigan/GitHub/[email protected]
[System]
quire-cli 1.0.0-rc.10
node v18.16.0
npm 9.5.1
os Darwin 21.6.0

Web Browser

Chrome Version 117.0.5938.88 (Official Build) (x86_64)

Relevant Terminal/Shell Output

N/A

Supporting Information

There are two separate Forewords in this project with two separate contributors, but only one contributor is listed with both Forewords.

Screen Shot 2023-10-06 at 1 55 41 PM
@Erin-Cecele
Copy link
Collaborator Author

Erin-Cecele commented Oct 6, 2023

This is similar to issue #847 but rather than the issue being with context=publicationContributors it's context=pageContributors.

@Erin-Cecele Erin-Cecele added bug Actual behavior does not match expected behavior quire-11ty This is an issue with the quire-11ty package labels Oct 11, 2023
@Erin-Cecele Erin-Cecele added status:backlog Issue is a lower priority but needs to eventually be addressed and removed status:triage needed Issue needs to be triaged by the Quire team. This label is automatically applied to new issues. labels Dec 6, 2023
@Erin-Cecele
Copy link
Collaborator Author

When I refer to "contributors mentioned/listed in the page YAML" I am specifically referring to the contributors added with:

contributors
  - first_name: 
    last_name: 

This is separate from contributors listed in the publication.yaml and added via an id in the page YAML, which this issue does not appear to affect.

@Erin-Cecele Erin-Cecele changed the title Page YAML contributors are being overwritten and only one is showing with ALL essays when using {% contributors %} shortcode with context=publicationContributors {% contributors context=publicationContributors %} is causing contributors created with first_name last_name in page YAML to be overwritten Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Actual behavior does not match expected behavior quire-11ty This is an issue with the quire-11ty package status:backlog Issue is a lower priority but needs to eventually be addressed
Projects
None yet
Development

No branches or pull requests

1 participant