Add filtering based on comps file to build stage script #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ehelms
force-pushed
the
filter-based-on-comps
branch
from
b11fe47 to
6eed4c2
Compare
|
After this is merged I plan to merge theforeman/jenkins-jobs#351 as I'll have a method that reproduces the Koji flow and output state for repositories. |
ehelms
commented
Sep 8, 2023
|
Successful test of this and output -- https://stagingyum.theforeman.org/client/nightly/el8/x86_64/ |
ekohl
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to not block on Copr, borrow from our mash script and implement comps filtering in the build stage script. This doesn't add any real overhead and we are already doing a copy and filter so might as well apply the comps filtering during that step.