Add create setting file step to Katello branch procedure #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Sep 6, 2023
procedures/katello/branch.md.erb
Outdated
| @@ -49,6 +49,7 @@ | |||
| - [ ] [pulpcore](https://github.com/theforeman/puppet-pulpcore) | |||
| - [ ] [foreman_proxy_content](https://github.com/theforeman/puppet-foreman_proxy_content) | |||
| - [ ] [katello](https://github.com/theforeman/puppet-katello) | |||
| - [ ] Commit the [settings file](https://github.com/theforeman/theforeman-rel-eng/blob/master/releases/katello/<%= release %>/settings) to the `theforeman-rel-eng` repository | |||
There was a problem hiding this comment.
Would it make sense to add a note about how to create it? or link to a commit that adds it for a previous version?
chris1984
force-pushed
the
add-setting
branch
from
8081d8e to
434a83f
Compare
|
@ekohl updated, let me know how this looks please. |
ekohl
reviewed
Sep 8, 2023
procedures/katello/branch.md.erb
Outdated
| @@ -33,6 +33,8 @@ | |||
|
|
|||
| ## Release Owner | |||
|
|
|||
| - [ ] Commit the [settings file](https://github.com/theforeman/theforeman-rel-eng/blob/master/releases/katello/<%= release %>/settings) to the `theforeman-rel-eng` repository | |||
| - [ ] See an example [here](https://github.com/theforeman/theforeman-rel-eng/commit/29b6b92e82de25c7a0e32fb9ca36468d8df0f6a1) | |||
There was a problem hiding this comment.
I'd not add a checkbox here since there's no real action to be taken. Perhaps even put it in a single line?
chris1984
force-pushed
the
add-setting
branch
from
434a83f to
8080b38
Compare
|
@ekohl updated to put it on one line, like you suggested. |
ekohl
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ekohl
Let me know if this is the correct place to put this