Fixes #37211 - Add ProxyPass for /images to support avatars #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgoetz
force-pushed
the
fix/proxypass_images
branch
from
ee6429c
to
623854c
Compare
ekohl
reviewed
Feb 27, 2024
There was a problem hiding this comment.
Digging through the source I can see we set this as the avatar path: https://github.com/theforeman/foreman/blob/c31702337015ecdf76aaa3053924b57007b8867f/app/models/auth_sources/auth_source_ldap.rb#L238-L240
And interestingly enough, we don't use this here because it's private: https://github.com/theforeman/foreman/blob/c31702337015ecdf76aaa3053924b57007b8867f/app/models/user.rb#L291-L292
Can you open a Redmine issue for this?
dgoetz
force-pushed
the
fix/proxypass_images
branch
from
623854c
to
52934ca
Compare
dgoetz
changed the title
|
Redmine issue was created as https://projects.theforeman.org/issues/37211, adjusted the commit message and force pushed it, adjusted also the title of the PR to reflect this. |
ekohl
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://community.theforeman.org/t/user-avatar-support-in-the-foreman-keep-it-or-drop-it/32271