Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Star count not updated #20

Open
steinitz opened this issue Dec 26, 2018 · 3 comments
Open

Star count not updated #20

steinitz opened this issue Dec 26, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@steinitz
Copy link

steinitz commented Dec 26, 2018

Hello,

Thanks for this course.

When I 'Star' a repo using this app, the app doesn't show the updated star count until I relaunch the app. Is this the expected behavior?

I thought I had a bug in my code and so checked the behavior of this repo.

EDIT: Oops, I just noticed the note about this on page 127 of the book. I'll close this issue.

@matthewboman
Copy link

@steinitz I'm having the same issue. What note are you referencing?

@steinitz
Copy link
Author

Yet, on the other side, the count of stargazers who have starred the repository isn’t updated because it cannot be retrieved from GitHub’s API.

appears on page number 127 (page 142 in my, and probably your, PDF reader's 'Go to page' feature).

You'll implement a star count update in a subsequent section of the book.

@rwieruch
Copy link
Member

I will reopen this issue in case anyone else stumbles into this and also to improve the writing of the book at this section. Thank you for mentioning it @steinitz 👍

@rwieruch rwieruch reopened this Jan 21, 2019
@rwieruch rwieruch added the enhancement New feature or request label Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants