Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh LGIrrep .jld2 files #9

Open
thchr opened this issue Aug 20, 2020 · 2 comments
Open

Refresh LGIrrep .jld2 files #9

thchr opened this issue Aug 20, 2020 · 2 comments
Labels
Low priority Low priority issues or enhancements; unlikely to get done

Comments

@thchr
Copy link
Owner

thchr commented Aug 20, 2020

I.e. run build/write_littlegroup_irreps_from_ISOTROPY.jl and save & commit new .jld2 files.

Use the new ISOTROPY dataset, which includes the fix for space group 214 (and then remove the method manually_fixed_lgir in build/parse_isotropy_ir.jl); see the https://github.com/thchr/Crystalline.jl/tree/update-isotropy-dataset branch that already takes some steps in this direction.

@thchr
Copy link
Owner Author

thchr commented Dec 10, 2020

Another good reason to do this is that it would probably fix the persistent .git issues with CRLF detection of these files.
Might as well also remove data/lgirreps/irrepmatrices.jld2 when do this; not used for anything right now.

@thchr
Copy link
Owner Author

thchr commented Feb 3, 2021

This is pretty much done, except for switching over to the new ISOTROPY dataset. There's not a lot of urgency to do that though; the data files had a lot of churn due to formatting changes etc., and while they still seem to work fine, there's no real point in doing it when we have a manual fix for SG 214 already.
Maybe worth doing if we ever get around to pulling the data files out into a separate repository.

@thchr thchr added the Low priority Low priority issues or enhancements; unlikely to get done label Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Low priority Low priority issues or enhancements; unlikely to get done
Projects
None yet
Development

No branches or pull requests

1 participant