Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluent/menu #218

Merged
merged 8 commits into from
Jul 24, 2024
Merged

Fluent/menu #218

merged 8 commits into from
Jul 24, 2024

Conversation

kandrelczyk
Copy link
Contributor

Sorry, I mixed something with my local branches. Here's new PR with dropdown renamed to menu.
There's the issue with external links in the dropdown.

@luoxiaozero
Copy link
Collaborator

There's the issue with external links in the dropdown.

I've only reproduced this issue in Firefox, and it seems to be caused by Callback. I've submitted a fix that you can try.

@kandrelczyk
Copy link
Contributor Author

It's working now, thanks. So weird it's specific to firefox.
Let me know if anything else needs to be changed or if it can be merged.

Also, what's next? Do you have a roadmap for the fluent branch?

@luoxiaozero
Copy link
Collaborator

Also, what's next? Do you have a roadmap for the fluent branch?

There are two pending tasks, one is to add generic support for Input and Textarea, and the other is to fix the #171 issue.

@luoxiaozero luoxiaozero merged commit a7918ef into thaw-ui:thaw/fluent Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants