Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking out the diff between master and idio master #2

Open
wants to merge 59 commits into
base: master
Choose a base branch
from

Conversation

tgalery
Copy link
Owner

@tgalery tgalery commented Sep 18, 2015

No description provided.

@nmadhire
Copy link

nmadhire commented Oct 8, 2015

@tgalery Please let me know if there are any issues. Also one thing to note is, instead of modifying the jwpl code, I copied the code into current directory. Most of the code you can see in dbpedia.spotlight packages.

@tgalery
Copy link
Owner Author

tgalery commented Oct 9, 2015

hey @naveenmadhire, actually it would be really nice to speak to you guys about this. Just so you understand, I'm trying to break the things both you and idio did in your respective repos and try to upstream it to diego's repo.

At the moment, I'm breaking down by funcionality. So I kind of extracted changes to the article parser idio did and created a new pr here #3 . There are a few changes in the way you and david did things, so it would be nice to talk, before sending this to him. Also, it would be nice to understand what else needs to be upstreamed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants