-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signals like SIGHUP aren't propogated #44
Comments
I think we should forward any signals received upward |
Okay. I have a local, minimal, ad hoc test case, and can at least look at a fix, but I'm not sure I have the time this week to work on a regression test. |
This may just be a problem with npm. I remember running into precisely this issue at client with a plain (non-scripty) npm script. Though that was back in npm 1.x days. No idea if it's been resolved with npm 2 or 3. |
@Schoonology still an issue, I presume? any chance to hack up a test case? |
I've decided to give up using
One more notice: don't forget to prepend your final #!/bin/sh
... some condiguring code ...
exec node ./app.js |
We're using scripty for our
npm start
script, undersupervisord
, in all environments. The supervisor is having difficulty shutting down the server, as it appears only scripty receives the signal (for one reason or another, we're not sure if it's configured for SIGHUP or SIGTERM at the moment).I can think of two reasonable solutions:
npm start
, under supervisors (e.g.supervisord
,upstart
), or both.The text was updated successfully, but these errors were encountered: