Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signals like SIGHUP aren't propogated #44

Open
Schoonology opened this issue Oct 12, 2016 · 5 comments
Open

Signals like SIGHUP aren't propogated #44

Schoonology opened this issue Oct 12, 2016 · 5 comments

Comments

@Schoonology
Copy link
Contributor

Schoonology commented Oct 12, 2016

We're using scripty for our npm start script, under supervisord, in all environments. The supervisor is having difficulty shutting down the server, as it appears only scripty receives the signal (for one reason or another, we're not sure if it's configured for SIGHUP or SIGTERM at the moment).

I can think of two reasonable solutions:

  1. Propagate signals through scripty to the managed process tree.
  2. Add to the documentation a recommendation against using scripty for npm start, under supervisors (e.g. supervisord, upstart), or both.
@searls
Copy link
Member

searls commented Oct 12, 2016

I think we should forward any signals received upward

@Schoonology
Copy link
Contributor Author

Okay. I have a local, minimal, ad hoc test case, and can at least look at a fix, but I'm not sure I have the time this week to work on a regression test.

@jasonkarns
Copy link
Member

jasonkarns commented Oct 12, 2016

This may just be a problem with npm. I remember running into precisely this issue at client with a plain (non-scripty) npm script. Though that was back in npm 1.x days. No idea if it's been resolved with npm 2 or 3.

@jasonkarns
Copy link
Member

@Schoonology still an issue, I presume? any chance to hack up a test case?

@korniychuk
Copy link

korniychuk commented Sep 26, 2021

I've decided to give up using scripty due to issues with SIGNALs and wrote.sh script paths directly to package.json. Eventually reducing the number of third-party dependencies is always good.

"start:prod": "scripty" -> "start:prod": "./npm-scripts/start/prod.sh"

One more notice: don't forget to prepend your final node calls with exec in .sh script. Otherwise, SIGNALs won't be transferred from SH to Node because if a child process started in blocking mode SH can't listen to signals.

#!/bin/sh
... some condiguring code ...
exec node ./app.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants