You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I find it strange that the dialect or driver parameter is hardcoded here (look screenshot below), because today there are many different methods and drivers for connecting to mysql. If I use something other than pymysql, I get the wrong connection address from the get_connection_url method.
Code:
Possible solution
Remove this hardcoded line and leave only mysql://...;
Allow you to pass an optional dialect or driver parameter to the get_connection_url function or the MySqlContainer class initializer. If its value is non-empty, then in the get_connection_url method it will be inserted into the right place in the connection string
To Reproduce
just see to current code (testcontainers 4.8.2)
Runtime environment
Looks optional for this issue
The text was updated successfully, but these errors were encountered:
nightblure
changed the title
Bug or enhancement: hardcoded dialect/driver parameter in connection url in mysql container
Bug and enhancement proposal: remove hardcoded dialect/driver parameter in connection url in mysql container
Oct 25, 2024
nightblure
changed the title
Bug and enhancement proposal: remove hardcoded dialect/driver parameter in connection url in mysql container
Bug: hardcoded dialect/driver parameter in connection url in mysql container
Oct 25, 2024
Describe the bug
I find it strange that the dialect or driver parameter is hardcoded here (look screenshot below), because today there are many different methods and drivers for connecting to mysql. If I use something other than pymysql, I get the wrong connection address from the
get_connection_url
method.Code:
Possible solution
mysql://...
;get_connection_url
function or theMySqlContainer
class initializer. If its value is non-empty, then in theget_connection_url
method it will be inserted into the right place in the connection stringTo Reproduce
Runtime environment
Looks optional for this issue
The text was updated successfully, but these errors were encountered: