fix(core): Add kwargs to image build #708
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #708 +/- ##
=======================================
Coverage ? 85.43%
=======================================
Files ? 12
Lines ? 659
Branches ? 103
=======================================
Hits ? 563
Misses ? 74
Partials ? 22 ☔ View full report in Codecov by Sentry. |
|
Can we perhaps add a hint to the docstring that kwargs will be passed down to docker-py? That would pretty much solve #614 for me. |
|
@black-snow Updated docstring as you suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #706, #614
Now when using kwargs in the Image API, the params are passed correctly into the build
Added relevant test + updated docstring to better reflect the usage