-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sub-directories for external dependencies of tesseract_collision #641
Add sub-directories for external dependencies of tesseract_collision #641
Conversation
@marip8 Do you mind if we leave the |
Then it may be better to update this function to leverage qhull to break the dependency on bullet for the core. |
To be clear, the function is still defined in There is not an easy way for me to keep the definition in I can take a look at |
If we decide to go the |
7a2b838
to
45fd883
Compare
How about just moving the createConvexHull to bullet directory. It should only require a few headers update and then the linking is not straight forward. |
Also it looks like vhacd depends on bullet also which it is not linking against which is why windows build is failing. |
Could also create a simple interface class like the ConvexDecomposition maybe ConvexComputer and then create an implementation in the bullet folder. |
c48a2e7
to
65e018d
Compare
… given the dependence on Bullet
65e018d
to
eef3630
Compare
Minor fixes to this in PR #649 |
This PR divides
tesseract_collision
into sub-directories based on the optional external dependencies each sub-directory introduces (bullet
,FCL
,VHACD
).Note: the function
createConvexHull
in the librarytesseract_collision_core
currently depends onbullet
API, so I left the function signature incore
but moved the implementation to thetesseract_collision_bullet
library. This means that any code that wants to usecreateConvexHull
(i.e. functions intesseract_urdf
) needs to link against thetesseract_collision_bullet
library until we find a better solution for uncoupling the creation of convex hulls frombullet
.