-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal for additional framework for building single-activity apps. #131
Comments
May be it wont be library artifact but will be good topics for Wiki pages. What do you think? |
I propose to describe these cases on the wiki:
Now in all projects on start AS puts a Jetpack Navigation that processes deeplink itself. When dev moving on, he expects this library to do the same. So describe that there is no built-in support, but it is done easily
|
Possible cases for the wiki:
|
Is it possible to avoid using abstractions for framework implementation? I don't think it's quiet good idea because in this case we can't use other frameworks like MOXY and e.t.c. |
Yes, I agree with you and wiki documentation looks more useful. I imagine this like cook-book with common cases |
@terrakok can you give some Cicerone with MvRx's BottomNavigation's demo? thanks a lot. |
@terrakok what is ETA for the new plans? Asking before own implementation. |
There isn't ETA. Just proposal and open discussion. |
Cool, just adding this to our project:
Also need to check how will it work with the next fragment. Let me know when you are open for PR. |
I'm always open for PRs and new ideas. |
Unfortunately, I failed since BottomSheetDialogFragment never will get in the back stack of the manager. I made a wrapper fragment that shows BSD and closes itself when BSD is fully dismissed. |
Welcome to #139 discussion 🤗 |
Call for suggestions!
What are base classes needed?
AppActivity
: global router, deep-links handler, back button handlerBaseFragment
: clear life-cycle, back button handlerFlowFragment
: nested navigation container, child-parent routersBottomNavigationFragment
: several FlowFragments with own backstacks, back button handlerThe text was updated successfully, but these errors were encountered: