-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unbonding name harmonization #205
Labels
good first issue
Good for newcomers
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Harmonize the
unboundings
because at the moment we haveunbondings
andundelegations
. Technically when we talk aboutundelegation
it is anunbound
. I would recommend to create a naming definition that talks about:BeginUnbonding
: when the unbond action is requested by the user (e.g method name Undelegate should be BeginUnbonding,CompleteUnbond
: when the action of transferring the tokens from the x/alliance account to the user account happens (e.g. the method CompleteUndelegations must be renamed to CompleteUnbond.Is important to take in consideration that the old entry points with the
undelegations
name must remain the same as now but must be deprecated, that way can be removed in a future release.The text was updated successfully, but these errors were encountered: