Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbonding name harmonization #205

Open
emidev98 opened this issue Jun 2, 2023 · 2 comments
Open

Unbonding name harmonization #205

emidev98 opened this issue Jun 2, 2023 · 2 comments
Labels
good first issue Good for newcomers

Comments

@emidev98
Copy link
Contributor

emidev98 commented Jun 2, 2023

Harmonize the unboundings because at the moment we have unbondings and undelegations. Technically when we talk about undelegation it is an unbound. I would recommend to create a naming definition that talks about:

  • BeginUnbonding: when the unbond action is requested by the user (e.g method name Undelegate should be BeginUnbonding,
  • CompleteUnbond: when the action of transferring the tokens from the x/alliance account to the user account happens (e.g. the method CompleteUndelegations must be renamed to CompleteUnbond.

there are more places in the code where this modifications need to be applied but these were just two of the many examples where the wording should be changed from undelegation to unbonding

Is important to take in consideration that the old entry points with the undelegations name must remain the same as now but must be deprecated, that way can be removed in a future release.

@emidev98 emidev98 added the good first issue Good for newcomers label Jun 2, 2023
@coderr01
Copy link

coderr01 commented Jun 2, 2023

@emidev98 i would like to contribute. Can you tell me from where to start ?

@emidev98 emidev98 changed the title Name harmonization Unbonding name harmonization Jun 2, 2023
@emidev98
Copy link
Contributor Author

emidev98 commented Jun 2, 2023

Hello @coderr01 I updated the issue with more info. I hope now it is better described where to start from

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants