Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

levelOffset + inheritPageImage #58

Open
asaage opened this issue Jun 2, 2024 · 4 comments
Open

levelOffset + inheritPageImage #58

asaage opened this issue Jun 2, 2024 · 4 comments

Comments

@asaage
Copy link

asaage commented Jun 2, 2024

The combination of levelOffset + inheritPageImage does not work like expected.
If the module is configured to display the second pageimage (Start level = 1) and "use parent image" is checked there is currently no output if the page has only one image set.
I think it would be logical to look for a second image in parent pages then.
What do you think - feasable?

@aschempp
Copy link
Member

that is not how this is currently designed 🤔. Either you set all images in a page, or none. For example, I used multiple images several times to generate a slider. I wouldn't want to get a slider of the parent images if my current page only has one image.

@asaage
Copy link
Author

asaage commented Jun 17, 2024

You would uncheck "use parent image" in this case wouldnt' you?
Or do you have one FEmodule that automatically decides whether to do a slider or a single-image?

My usecase has two FEmodules which display images in different places 🤷‍♂️.
Can't wrap my head around if its possible to make a configuration that suits both needs at the moment.
I guess i'm just going to assign all images to all my pages then. Feel free to close this!

@aschempp
Copy link
Member

aschempp commented Jul 8, 2024

Or do you have one FEmodule that automatically decides whether to do a slider or a single-image?

Yes I have (a template actually).

My usecase has two FEmodules which display images in different places 🤷‍♂️.
Can't wrap my head around if its possible to make a configuration that suits both needs at the moment.
I guess i'm just going to assign all images to all my pages then. Feel free to close this!

Hmm, that totally makes sense. Maybe we should inherit if you have set a levelOffset bigger than 1 (and the inherit checkbox). For my case, I never have an offset (I have multiple images though).

@asaage
Copy link
Author

asaage commented Jul 8, 2024

Maybe we should inherit if you have set a levelOffset bigger than 1 (and the inherit checkbox).

probably maybe dontknow...🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants