race condition bug in docs example

[verhulstm]

the example file provision.sh at https://terminallabs-rambo.readthedocs.io/en/latest/core/provisioning/ has a race condition in it.

between:

echo "Installing Salt with master and Python 3"
bash bootstrap-salt.sh -M -x python3

echo "Accepting the local minion's key"
salt-key -A -y

this often fails. but it is also random. after installing the salt system the minions take some time to start up. if the minion is not fully loaded by the time "salt-key -A -y" is run the whole build will fail.

i put in a sleep 5s delay to give the minion time to load and send it's key to the master. that fixed it for now

[nixjdm]

Ok, yeah, that's annoying. Maybe I'll post an issue for salt about this. I've handled the same thing in the next step of the script by checking the exit codes. I'll do that here too.