Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Tuple and CartesianIndex types when passing pivots #29

Open
rittermarc opened this issue Jul 18, 2024 · 1 comment
Open

Support Tuple and CartesianIndex types when passing pivots #29

rittermarc opened this issue Jul 18, 2024 · 1 comment

Comments

@rittermarc
Copy link
Member

Users are likely to have indices as Tuple or CartesianIndex. Functions such as addglobalpivots! only accept vectors. Based on user feedback during the tutorial session, it would be helpful to make the interface more flexible such that the user doesn't have to convert pivot specifications all the time.

@shinaoka
Copy link
Member

shinaoka commented Jul 18, 2024

OK, let us override the function!
I want to avoid using Union to accept these types as this could lead to type instability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants