[Bug] Devnet generator sets consensus fee recipient to Address::ZERO

[Malcer]

Describe the bug

Describe the bug

In xtask/src/generate_devnet.rs, the consensus_fee_recipient is currently hardcoded to Address::ZERO.

There is a FIXME comment in the code confirming this:

// FIXME(janis): this should not be zero
consensus_fee_recipient: Address::ZERO,

Impact

Validators on the local devnet burn their gas fees instead of collecting them, causing inaccurate economic simulation compared to mainnet

Proposed Solution

1. Extend Validator struct in genesis_args.rs to include the fee recipient address.
2. Propagate the real address in generate_devnet.rs instead of using Address::ZERO.

I have investigated this and can work on a fix if verified.

Steps to reproduce

1. Open the file xtask/src/generate_devnet.rs.
2. Locate the run function implementation.
3. Observe the Validator configuration block (around line 123).
4. Notice that consensus_fee_recipient is hardcoded to Address::ZERO with a FIXME comment.

Logs

// Current code in xtask/src/generate_devnet.rs:

// FIXME(janis): this should not be zero
consensus_fee_recipient: Address::ZERO,

Platform(s)

Mac (Apple Silicon)

Container Type

Not running in a container

What version/commit are you on?

Latest main branch

If you've built from source, provide the full command you used

No response

Code of Conduct

• I agree to follow the Code of Conduct