-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve signalWithStart usability #915
Comments
Such refactoring should keep the strongly typed way to call this method the current implementation provides. |
Wanted to suggest one possible improvement.
( or just create an untyped stub to start with ) so this works off just WorkflowStub (untyped) WorkflowClient.signalWithStart only works off typed stubs, for example:
It would be nice to add an "untyped" option for WorkflowClient.signalWithStart that takes in signalName, signalData, inputData. Bonus question, whats the use for WorkflowClient.signalWithStart? When would you use it instead of WorkflowStub.signalWithStart? |
We've recently shipped updateWithStart in pre-release, and we hope it has better usability. |
Closing as a duplicate of #2213 |
Workflow#signalWithStart
method interface is overcomplicated and hard to use without checking with samples first.We should improve the classes structure and provide more conventional builders and factory methods around this method and functionality.
The text was updated successfully, but these errors were encountered: