Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilize Signal requestId field for signal gRPC retries deduplication #1655

Open
Spikhalskiy opened this issue Feb 15, 2023 · 0 comments · May be fixed by #2352
Open

Utilize Signal requestId field for signal gRPC retries deduplication #1655

Spikhalskiy opened this issue Feb 15, 2023 · 0 comments · May be fixed by #2352
Labels
enhancement User experience

Comments

@Spikhalskiy
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Temporal Server API exposes SignalWorkflowExecutionRequest#request_id that allows deduplicating (without guarantees) signal retry attempts. This allows deduplicating signal requests if the signal request experiences a gRPC error, but comes through from the Server point of view and gets retried.
Currently, JavaSDK doesn't utilize this mechanic

Describe the solution you'd like
Generate a unique UUID for each user-facing signal API and utilize SignalWorkflowExecutionRequest#request_id
@Spikhalskiy Spikhalskiy added the enhancement User experience label Feb 15, 2023
@Spikhalskiy Spikhalskiy changed the title JavaSDK should utilize Signal requestId field for retries deduplication Utilize Signal requestId field for signal gRPC retries deduplication Feb 15, 2023
@Quinn-With-Two-Ns Quinn-With-Two-Ns linked a pull request Dec 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement User experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set request Id on SignalWorkflowExecutionRequest Quinn-With-Two-Ns/sdk-java
1 participant
@Spikhalskiy