Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an easy way to run all the samples #16

Closed
markmark206 opened this issue Apr 17, 2020 · 2 comments
Closed

Create an easy way to run all the samples #16

markmark206 opened this issue Apr 17, 2020 · 2 comments

Comments

@markmark206
Copy link

markmark206 commented Apr 17, 2020

Create make target to run all the samples, given a frontend endpoint (e. g. FRONTEND_ADDRESS=127.0.0.1:7233 make run). Integrate it with #15.

This will enable two use cases:

  1. a dev making change on their machine, and wanting to make sure things still work before submitting a PR
  2. CI/CD pipeline running samples against a staging environment as part of its validation of the repo (and, indirectly, of the code deployed to the staging environment).
@alexshtin alexshtin changed the title create an easy way (a make target?) to run all the samples Create an easy way to run all the samples Jun 26, 2020
@alexshtin
Copy link
Member

This might not be needed if we implement #34 correctly.

@vitarb
Copy link
Contributor

vitarb commented Nov 25, 2020

Closed as a duplicate

@vitarb vitarb closed this as completed Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants