Add pull_policy to pod init Config #1200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the `uses_postgres_image()` method to `Config` in the `tembo-pod-init` package. Like the method with the same name in `CoreDBSpec` in `tembo-operator`, the method returns true when the image is a base image and false when it's not. Also add `image_pull_policy()`, which returns returns "Always" when the image name is `postgres` and its tag includes a Postgres major version and OS name. This ensures that on every pod init, it will pull the latest image for that OS and Postgres version. For all other cases it only pulls "IfNotExists". Increment tembo-pod-stacks to v0.2.1.
nhudson
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
uses_postgres_image()method toConfigin thetembo-pod-initpackage. Like the method with the same name inCoreDBSpecintembo-operator, the method returns true when the image is a base image and false when it's not.Also add
image_pull_policy(), which returns returns "Always" when the image name ispostgresand its tag includes a Postgres major version and OS name. This ensures that on every pod init, it will pull the latest image for that OS and Postgres version. For all other cases it only pulls "IfNotExists".Increment tembo-pod-stacks to v0.2.1. Closes TEM-3531.