Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReadMe Does not match the latest Docker image release #206

Open
jbigel277 opened this issue May 27, 2020 · 3 comments
Open

ReadMe Does not match the latest Docker image release #206

jbigel277 opened this issue May 27, 2020 · 3 comments

Comments

@jbigel277
Copy link

The current ReadMe describes the use of an additional parameter (https://github.com/telia-oss/github-pr-resource#get) under "get" where "submodules" can be added however that functionality is not in the v0.21.0 release. The code is already in the master branch a new release just needs to be cut.
@itsdalmo
Copy link
Contributor

You can use the dev tag to test features currently on master. Unfortunately I think we need to merge #200 or find a better solution (without --global) before we can make a new release.

@jbigel277
Copy link
Author

jbigel277 commented May 27, 2020 •
edited
Loading

Okay so I switched to the dev tag but now I have this error
"Host key verification failed."
We don't use a host key. The reason we've switched from "jtarchie/pr" to "teliaoss/github-pr-resource" is because it's supposed to be using HTTPS and we have a key for that.

@itsdalmo
Copy link
Contributor

Yep, I think the cause of the error you are seeing is being worked on in #200. Will have to wait until that lands on master to recursively fetch submodules unfortunately.

cwsatpolymath added a commit to PolymeshAssociation/Polymesh that referenced this issue Aug 4, 2020
@cwsatpolymath
Add dev tag to github-pr resource docker image
604eac2 
Workaround to enable submodules.  See telia-oss/github-pr-resource#206
adamdossa pushed a commit to PolymeshAssociation/Polymesh that referenced this issue Aug 5, 2020
@cwsatpolymath
Devops 131/concourse core integration (#505)
3053237 
* Concourse pipelines

* Use secrets for Slack webhook URLs

* Updated secret references

* Production readiness updates

* Add dockerfiles
* Update secrets
* Fix resource order

* Updte pipeline secrets

* Concourse pipelines

* Use secrets for Slack webhook URLs

* Updated secret references

* Production readiness updates

* Add dockerfiles
* Update secrets
* Fix resource order

* Updte pipeline secrets

* DEVOPS-131/concourse-core-integration

* Remove `-j 1` fallback builds
* Don't sync `cargo build` and `cargo test` caches.

* DEVOPS-131/concourse-core-integration

* Add timeout to integration tests

* DEVOPS-131/concourse-core-integration

Make disabling of fork PRs explicit

* Enable submodule cloning

* Add dev tag to github-pr resource docker image

Workaround to enable submodules.  See telia-oss/github-pr-resource#206

* DEVOPS-131/concourse-core-integration

Submodule credentials workaround

* DEVOPS-131/concourse-core-integration

Fix file path in condition

* DEVOPS-131/concourse-core-integration

* Update cargo test step to fetch submodules

* DEVOPS-131/concourse-core-integration

* Update cargo test packages

* DEVOPS-131/concourse-core-integration

Enable toolchain for `cargo test`

* DEVOPS-131/concourse-core-integration

* Update `cargo test` container

* DEVOPS-131/concourse-core-integration

* Update `master` and `tooling` branch and PR pipelines
* Update build step to have the binary report the build version
adamdossa pushed a commit to PolymeshAssociation/Polymesh that referenced this issue Aug 14, 2020
@cwsatpolymath @adamdossa
Devops 131/concourse core integration (#505)
5a05972 
* Concourse pipelines

* Use secrets for Slack webhook URLs

* Updated secret references

* Production readiness updates

* Add dockerfiles
* Update secrets
* Fix resource order

* Updte pipeline secrets

* Concourse pipelines

* Use secrets for Slack webhook URLs

* Updated secret references

* Production readiness updates

* Add dockerfiles
* Update secrets
* Fix resource order

* Updte pipeline secrets

* DEVOPS-131/concourse-core-integration

* Remove `-j 1` fallback builds
* Don't sync `cargo build` and `cargo test` caches.

* DEVOPS-131/concourse-core-integration

* Add timeout to integration tests

* DEVOPS-131/concourse-core-integration

Make disabling of fork PRs explicit

* Enable submodule cloning

* Add dev tag to github-pr resource docker image

Workaround to enable submodules.  See telia-oss/github-pr-resource#206

* DEVOPS-131/concourse-core-integration

Submodule credentials workaround

* DEVOPS-131/concourse-core-integration

Fix file path in condition

* DEVOPS-131/concourse-core-integration

* Update cargo test step to fetch submodules

* DEVOPS-131/concourse-core-integration

* Update cargo test packages

* DEVOPS-131/concourse-core-integration

Enable toolchain for `cargo test`

* DEVOPS-131/concourse-core-integration

* Update `cargo test` container

* DEVOPS-131/concourse-core-integration

* Update `master` and `tooling` branch and PR pipelines
* Update build step to have the binary report the build version
adamdossa pushed a commit to PolymeshAssociation/Polymesh that referenced this issue Aug 14, 2020
@cwsatpolymath @adamdossa
Devops 131/concourse core integration (#505)
fe563bd 
* Concourse pipelines

* Use secrets for Slack webhook URLs

* Updated secret references

* Production readiness updates

* Add dockerfiles
* Update secrets
* Fix resource order

* Updte pipeline secrets

* Concourse pipelines

* Use secrets for Slack webhook URLs

* Updated secret references

* Production readiness updates

* Add dockerfiles
* Update secrets
* Fix resource order

* Updte pipeline secrets

* DEVOPS-131/concourse-core-integration

* Remove `-j 1` fallback builds
* Don't sync `cargo build` and `cargo test` caches.

* DEVOPS-131/concourse-core-integration

* Add timeout to integration tests

* DEVOPS-131/concourse-core-integration

Make disabling of fork PRs explicit

* Enable submodule cloning

* Add dev tag to github-pr resource docker image

Workaround to enable submodules.  See telia-oss/github-pr-resource#206

* DEVOPS-131/concourse-core-integration

Submodule credentials workaround

* DEVOPS-131/concourse-core-integration

Fix file path in condition

* DEVOPS-131/concourse-core-integration

* Update cargo test step to fetch submodules

* DEVOPS-131/concourse-core-integration

* Update cargo test packages

* DEVOPS-131/concourse-core-integration

Enable toolchain for `cargo test`

* DEVOPS-131/concourse-core-integration

* Update `cargo test` container

* DEVOPS-131/concourse-core-integration

* Update `master` and `tooling` branch and PR pipelines
* Update build step to have the binary report the build version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@itsdalmo @jbigel277