Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix collectAttributes dealing with EXTENDED_ARG #428

Closed
tekknolagi opened this issue Apr 11, 2023 · 0 comments · Fixed by #446 · May be fixed by #432
Closed

Fix collectAttributes dealing with EXTENDED_ARG #428

tekknolagi opened this issue Apr 11, 2023 · 0 comments · Fixed by #446 · May be fixed by #432
Labels
good first issue Good for newcomers

Comments

@tekknolagi
Copy link
Owner

tekknolagi commented Apr 11, 2023 •
edited
Loading

It should skip over all the EXTENDED_ARG and the following instruction -- right now it assumes there is at most one. Make the if a while.
@tekknolagi tekknolagi added the good first issue Good for newcomers label Apr 11, 2023
@tekknolagi tekknolagi mentioned this issue Apr 17, 2023
Open
@tekknolagi tekknolagi mentioned this issue Apr 29, 2023
Merged
tekknolagi added a commit that referenced this issue Apr 29, 2023
@tekknolagi
Parse EXTENDED_ARG in Runtime::collectAttributes
1379050 
Add and modify tests.

Fix #428
@tekknolagi tekknolagi mentioned this issue Apr 29, 2023
Merged
tekknolagi added a commit that referenced this issue Apr 29, 2023
@tekknolagi
Parse EXTENDED_ARG in Runtime::collectAttributes
2f1bc0c 
Add and modify tests.

Fix #428
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
1 participant
@tekknolagi