fix lints

packages/process_run/analysis_options.yaml

@@ -23,21 +23,32 @@ analyzer:
 
 linter:
   rules:
-    - public_member_api_docs
     - always_declare_return_types
     - avoid_dynamic_calls
+    - avoid_print
     - avoid_slow_async_io
     - cancel_subscriptions
+    - deprecated_member_use_from_same_package
     - directives_ordering
+    - implicit_reopen
+    - invalid_case_patterns
+    - invalid_runtime_check_with_js_interop_types
+    - iterable_contains_unrelated_type
+    - list_remove_unrelated_type
     - no_adjacent_strings_in_list
+    - no_literal_bool_comparisons
+    - no_self_assignments
     - omit_local_variable_types
     - package_api_docs
+    - package_prefixed_library_names
     - prefer_const_constructors
+    - prefer_const_literals_to_create_immutables
+    - prefer_if_elements_to_conditional_expressions
     - prefer_single_quotes
+    - public_member_api_docs
     - sort_child_properties_last
     - test_types_in_equals
     - throw_in_finally
     - unawaited_futures
-    - unnecessary_null_aware_assignments
     - unnecessary_statements
     - unsafe_html

packages/process_run/example/dart_bin_version.dart

@@ -2,10 +2,11 @@ import 'dart:async';
 
 import 'package:process_run/cmd_run.dart';
 import 'package:process_run/shell.dart';
+import 'package:process_run/stdio.dart';
 
 Future main() async {
-  print('dart: ${await which('dart')}');
+  stdout.writeln('dart: ${await which('dart')}');
   var dartBinVersion = await getDartBinVersion();
-  print('dartBinVersion: $dartBinVersion');
+  stdout.writeln('dartBinVersion: $dartBinVersion');
   await Shell().run('dart --version');
 }

packages/process_run/example/demo_sync.dart

@@ -7,7 +7,8 @@ void main() {
   // This is a synchronous call and will block until the child process terminates.
   var results = shell.runSync('echo "Hello world"');
   var result = results.first;
-  print('output: "${result.outText.trim()}" exitCode: ${result.exitCode}');
+  stdout.writeln(
+      'output: "${result.outText.trim()}" exitCode: ${result.exitCode}');
   // should display: output: "Hello world" exitCode: 0
 
   // Run the command

packages/process_run/example/flutter_bin_version.dart

@@ -1,10 +1,11 @@
 import 'dart:async';
 
 import 'package:process_run/cmd_run.dart';
+import 'package:process_run/stdio.dart';
 import 'package:process_run/which.dart';
 
 Future main() async {
-  print('flutter: ${await which('flutter')}');
+  stdout.writeln('flutter: ${await which('flutter')}');
   var flutterBinVersion = await getFlutterBinVersion();
-  print('flutterBinVersion: $flutterBinVersion');
+  stdout.writeln('flutterBinVersion: $flutterBinVersion');
 }

packages/process_run/example/info.dart

@@ -2,11 +2,12 @@ import 'dart:async';
 
 import 'package:process_run/cmd_run.dart' show flutterExecutablePath;
 import 'package:process_run/shell.dart';
+import 'package:process_run/stdio.dart';
 
 Future main() async {
-  print('dartExecutable: $dartExecutable');
-  print('flutterExecutablePath: $flutterExecutablePath');
-  print('which(\'dart\'): ${await which('dart')}');
-  print('which(\'flutter\'): ${await which('flutter')}');
+  stdout.writeln('dartExecutable: $dartExecutable');
+  stdout.writeln('flutterExecutablePath: $flutterExecutablePath');
+  stdout.writeln('which(\'dart\'): ${await which('dart')}');
+  stdout.writeln('which(\'flutter\'): ${await which('flutter')}');
   await run('dart --version');
 }

packages/process_run/example/my_script.dart

@@ -1,3 +1,5 @@
+import 'package:process_run/stdio.dart';
+
 void main(List<String> arguments) {
-  print(arguments);
+  stdout.writeln(arguments);
 }

packages/process_run/example/no_env_user_paths.dart

@@ -1,10 +1,11 @@
 import 'dart:async';
 
 import 'package:process_run/src/user_config.dart';
+import 'package:process_run/stdio.dart';
 
 Future main() async {
   var userPaths = getUserPaths(<String, String>{});
   for (var path in userPaths) {
-    print(path);
+    stdout.writeln(path);
   }
 }

packages/process_run/example/prompt.dart

@@ -2,9 +2,10 @@ import 'dart:async';
 
 import 'package:process_run/shell_run.dart';
 import 'package:process_run/src/prompt.dart';
+import 'package:process_run/stdio.dart';
 
 Future main() async {
-  print(await prompt('Enter your name'));
-  print(await promptConfirm('Action'));
+  stdout.writeln(await prompt('Enter your name'));
+  stdout.writeln(await promptConfirm('Action'));
   await promptTerminate();
 }

packages/process_run/example/shell/shell_common.dart

@@ -1,3 +1,5 @@
+// ignore_for_file: avoid_print
+
 import 'package:process_run/shell.dart';
 
 Future<void> main() async {

packages/process_run/example/streamer.dart

@@ -87,6 +87,7 @@ Future main(List<String> arguments) async {
       await Future<void>.delayed(Duration(microseconds: delay));
     }
     index++;
+    // ignore: avoid_print
     print('[$index]');
   }
 

packages/process_run/example/user_paths.dart

@@ -6,6 +6,6 @@ import 'package:process_run/src/user_config.dart';
 Future main() async {
   var userPaths = getUserPaths(Platform.environment);
   for (var path in userPaths) {
-    print(path);
+    stdout.writeln(path);
   }
 }

packages/process_run/lib/src/bin/shell/env_delete.dart

@@ -18,7 +18,7 @@ class ShellEnvDeleteCommand extends ShellEnvCommandBase {
   FutureOr<bool> onRun() async {
     var path = envFilePath;
     if (verbose!) {
-      print('envFilePath: $path');
+      stdout.writeln('envFilePath: $path');
     }
     var force = getFlag(flagForce)!;
 

packages/process_run/lib/src/bin/shell/env_edit.dart

@@ -13,7 +13,7 @@ class ShellEnvEditCommand extends ShellEnvCommandBase {
   @override
   FutureOr<bool> onRun() async {
     if (verbose!) {
-      print('envFilePath: $envFilePath');
+      stdout.writeln('envFilePath: $envFilePath');
     }
     await envFileReadOrCreate(write: true);
 
@@ -41,7 +41,7 @@ class ShellEnvEditCommand extends ShellEnvCommandBase {
       await doRun('vi ${shellArgument(envFilePath!)}');
       return true;
     }
-    print('no editor found');
+    stdout.writeln('no editor found');
     return false;
   }
 }

packages/process_run/lib/src/bin/shell/run.dart

@@ -64,7 +64,7 @@ class ShellRunCommand extends ShellBinCommand {
       exit(1);
     }
     if (verbose!) {
-      print('command: $command');
+      stdout.writeln('command: $command');
     }
     await run(command);
     return true;

packages/process_run/lib/src/common/dev_utils.dart

@@ -5,6 +5,7 @@ import 'package:meta/meta.dart';
 
 void _devPrint(Object object) {
   if (_devPrintEnabled) {
+    // ignore: avoid_print
     print(object);
   }
 }
@@ -14,11 +15,11 @@ bool _devPrintEnabled = true;
 @Deprecated('Dev only')
 set devPrintEnabled(bool enabled) => _devPrintEnabled = enabled;
 
-@Deprecated('Dev only')
-
 /// Print only in dev mode
+@Deprecated('Dev only')
 void devPrint(Object? object) {
   if (_devPrintEnabled) {
+    // ignore: avoid_print
     print(object);
   }
 }
@@ -34,7 +35,9 @@ void _devError([Object? msg]) {
     throw UnsupportedError('$msg');
   } catch (e, st) {
     if (_devPrintEnabled) {
+      // ignore: avoid_print
       print('# ERROR $msg');
+      // ignore: avoid_print
       print(st);
     }
     rethrow;

packages/process_run/lib/src/lines_utils_common.dart

@@ -87,6 +87,7 @@ Stream<String> shellStreamLines(Stream<List<int>> stream,
           ctlr.add(encoding!.decode(currentLine!));
         } catch (_) {
           // Ignore bad encoding
+          // ignore: avoid_print
           print('ignoring: $currentLine');
         }
       }
@@ -97,6 +98,7 @@ Stream<String> shellStreamLines(Stream<List<int>> stream,
   ctlr = StreamController<String>(
       onPause: () {
         if (shellDebug) {
+          // ignore: avoid_print
           print('onPause (paused: ${subscription?.isPaused})');
         }
         // Last one

packages/process_run/lib/src/process_run.dart

@@ -82,6 +82,7 @@ Future<ProcessResult> runExecutableArguments(
         includeParentEnvironment: false,
         runInShell: runInShell);
     if (shellDebug) {
+      // ignore: avoid_print
       print('process: ${process.pid}');
     }
     if (onProcess != null) {
@@ -92,8 +93,10 @@ Future<ProcessResult> runExecutableArguments(
       () async {
         try {
           var exitCode = await process.exitCode;
+          // ignore: avoid_print
           print('process: ${process.pid} exitCode $exitCode');
         } catch (e) {
+          // ignore: avoid_print
           print('process: ${process.pid} Error $e waiting exit code');
         }
       }();

packages/process_run/lib/src/shell.dart

@@ -455,6 +455,7 @@ abstract class Shell implements ShellCore, ShellCoreSync {
 
   void _clearPreviousContext() {
     if (shellDebug) {
+      // ignore: avoid_print
       print(
           'Clear previous context ${_currentProcessResultCompleter?.isCompleted}');
     }
@@ -485,6 +486,7 @@ abstract class Shell implements ShellCore, ShellCoreSync {
 
       try {
         if (shellDebug) {
+          // ignore: avoid_print
           print('$_runId: Before $processCmd');
         }
 
@@ -498,6 +500,7 @@ abstract class Shell implements ShellCore, ShellCoreSync {
             workingDirectory: _options.workingDirectory);
       } finally {
         if (shellDebug) {
+          // ignore: avoid_print
           print(
               '$_runId: After $executableFullPath exitCode ${processResult?.exitCode}');
         }
@@ -566,6 +569,7 @@ abstract class Shell implements ShellCore, ShellCoreSync {
         try {
           // devPrint(_options.environment.keys.where((element) => element.contains('TEKARTIK')));
           if (shellDebug) {
+            // ignore: avoid_print
             print('$_runId: Before $processCmd');
           }
 
@@ -582,13 +586,15 @@ abstract class Shell implements ShellCore, ShellCoreSync {
               _currentProcessCmd = processCmd;
               _currentProcessRunId = runId;
               if (shellDebug) {
+                // ignore: avoid_print
                 print('onProcess ${_currentProcessToString()}');
               }
               if (onProcess != null) {
                 onProcess(process);
               }
               if (_killedRunId >= _runId) {
                 if (shellDebug) {
+                  // ignore: avoid_print
                   print('shell was killed');
                 }
                 _kill();
@@ -597,6 +603,7 @@ abstract class Shell implements ShellCore, ShellCoreSync {
             });
           } finally {
             if (shellDebug) {
+              // ignore: avoid_print
               print(
                   '$_runId: After $processCmd exitCode ${processResult?.exitCode}');
             }
@@ -637,13 +644,15 @@ abstract class Shell implements ShellCore, ShellCoreSync {
 
       run().then((value) {
         if (shellDebug) {
+          // ignore: avoid_print
           print('$runId: done');
         }
         if (!completer.isCompleted) {
           completer.complete(value);
         }
       }).catchError((Object e) {
         if (shellDebug) {
+          // ignore: avoid_print
           print('$runId: error $e');
         }
         if (!completer.isCompleted) {

packages/process_run/lib/src/stdio/shell_streamer_io.dart

@@ -25,7 +25,7 @@ class ShellOutputLinesStreamerIo
   set current(bool current) {
     if (this.current != current) {
       super.current = current;
-      if (current == true) {
+      if (current) {
         dump();
       }
     }

packages/process_run/test/dart_doc_test.dart

@@ -1,3 +1,5 @@
+// ignore_for_file: avoid_print
+
 @TestOn('vm')
 library process_run.dartdoc_test;
 

packages/process_run/test/dartbin_test.dart

@@ -1,3 +1,5 @@
+// ignore_for_file: avoid_print
+
 @TestOn('vm')
 library process_run.dartbin_test;
 

packages/process_run/test/data/main.dart

@@ -1,3 +1,5 @@
+// ignore_for_file: avoid_print
+
 void main() {
   print('Hello');
 }

packages/process_run/test/process_run_in_test2_.dart

@@ -1,3 +1,5 @@
+// ignore_for_file: avoid_print
+
 @TestOn('vm')
 library process_run.process_run_in_test2_;
 

packages/process_run/test/process_run_in_test_.dart

@@ -1,3 +1,5 @@
+// ignore_for_file: avoid_print
+
 @TestOn('vm')
 library process_run.process_run_in_test;
 

packages/process_run/test/process_run_test.dart

@@ -1,3 +1,5 @@
+// ignore_for_file: avoid_print
+
 @TestOn('vm')
 library process_run.process_run_test;
 

packages/process_run/test/shell_common_test.dart

@@ -1,3 +1,5 @@
+// ignore_for_file: avoid_print
+
 library process_run.test.shell_common_api_test;
 
 import 'dart:async';

packages/process_run/test/shell_environment_test.dart

@@ -1,3 +1,5 @@
+// ignore_for_file: avoid_print
+
 @TestOn('vm')
 library process_run.test.shell_environment_test;
 

packages/process_run/test/shell_run_test.dart

@@ -1,3 +1,5 @@
+// ignore_for_file: avoid_print
+
 @TestOn('vm')
 library process_run.test.shell_run_test;
 

packages/process_run/test/shell_test.dart

@@ -1,3 +1,5 @@
+// ignore_for_file: avoid_print
+
 @TestOn('vm')
 library process_run.test.shell_test;
 

packages/process_run/test/which_test.dart

@@ -1,3 +1,5 @@
+// ignore_for_file: avoid_print
+
 @TestOn('vm')
 library process_run.which_test;