logging: simplified log levels (kopia#954)

Removed Warning, Notify and Fatal:

* `Warning` => `Error` or `Info`
* `Notify` => `Info`
* `Fatal` was never used.

Note that --log-level=warning is still supported for backwards
compatibility, but it is the same as --log-level=error.

Co-authored-by: Julio López <[email protected]>

Author: jkowalski

cli/app.go

@@ -199,7 +199,7 @@ func maybeRepositoryAction(act func(ctx context.Context, rep repo.Repository) er
 
 			if rep != nil && !mode.disableMaintenance {
 				if merr := maybeRunMaintenance(ctx, rep); merr != nil {
-					log(ctx).Warningf("error running maintenance: %v", merr)
+					log(ctx).Errorf("error running maintenance: %v", merr)
 				}
 			}
 

cli/auto_upgrade.go

@@ -25,7 +25,7 @@ func maybeAutoUpgradeRepository(ctx context.Context, r repo.Repository) error {
 		return nil
 	}
 
-	log(ctx).Noticef("Setting default maintenance parameters...")
+	log(ctx).Debugf("Setting default maintenance parameters...")
 
 	return repo.DirectWriteSession(ctx, dr, repo.WriteSessionOptions{
 		Purpose: "setDefaultMaintenanceParameters",
@@ -42,8 +42,8 @@ func setDefaultMaintenanceParameters(ctx context.Context, rep repo.RepositoryWri
 		return errors.Wrap(err, "unable to set maintenance params")
 	}
 
-	log(ctx).Noticef(`
-Kopia will perform quick maintenance of the repository automatically every %v
+	log(ctx).Infof(`
+NOTE: Kopia will perform quick maintenance of the repository automatically every %v
 and full maintenance every %v when running as %v.
 
 See https://kopia.io/docs/advanced/maintenance/ for more information.

cli/command_index_recover.go

@@ -56,7 +56,7 @@ func runRecoverBlockIndexesAction(ctx context.Context, rep repo.DirectRepository
 func recoverIndexFromSinglePackFile(ctx context.Context, rep repo.DirectRepositoryWriter, blobID blob.ID, length int64, totalCount *int) {
 	recovered, err := rep.ContentManager().RecoverIndexFromPackBlob(ctx, blobID, length, *blockIndexRecoverCommit)
 	if err != nil {
-		log(ctx).Warningf("unable to recover index from %v: %v", blobID, err)
+		log(ctx).Errorf("unable to recover index from %v: %v", blobID, err)
 		return
 	}
 

cli/command_mount.go

@@ -67,7 +67,7 @@ func runMountCommand(ctx context.Context, rep repo.Repository) error {
 
 	if *mountPointBrowse {
 		if err := open.Start(ctrl.MountPath()); err != nil {
-			log(ctx).Warningf("unable to browse %v", err)
+			log(ctx).Errorf("unable to browse %v", err)
 		}
 	}
 

cli/command_repository_sync.go

@@ -39,7 +39,7 @@ func runSyncWithStorage(ctx context.Context, src blob.Reader, dst blob.Storage)
 	log(ctx).Infof("  Destination: %v", dst.DisplayName())
 
 	if !*repositorySyncDelete {
-		log(ctx).Noticef("NOTE: By default no BLOBs are deleted, pass --delete to allow it.")
+		log(ctx).Infof("NOTE: By default no BLOBs are deleted, pass --delete to allow it.")
 	}
 
 	if err := ensureRepositoriesHaveSameFormatBlob(ctx, src, dst); err != nil {
@@ -270,7 +270,7 @@ func syncCopyBlob(ctx context.Context, m blob.Metadata, src blob.Reader, dst blo
 		if err := dst.SetTime(ctx, m.BlobID, m.Timestamp); err != nil {
 			if errors.Is(err, blob.ErrSetTimeUnsupported) {
 				setTimeUnsupportedOnce.Do(func() {
-					log(ctx).Warningf("destination repository does not support setting time")
+					log(ctx).Infof("destination repository does not support setting time")
 				})
 			}
 

cli/command_server_start.go

@@ -100,7 +100,7 @@ func runServer(ctx context.Context, rep repo.Repository) error {
 		log(ctx).Infof("Shutting down...")
 
 		if err = httpServer.Shutdown(ctx); err != nil {
-			log(ctx).Warningf("unable to shut down: %v", err)
+			log(ctx).Debugf("unable to shut down: %v", err)
 		}
 	})
 
@@ -131,7 +131,7 @@ func runServer(ctx context.Context, rep repo.Repository) error {
 
 	onExternalConfigReloadRequest(func() {
 		if rerr := srv.Refresh(ctx); rerr != nil {
-			log(ctx).Warningf("refresh failed: %v", rerr)
+			log(ctx).Errorf("refresh failed: %v", rerr)
 		}
 	})
 
@@ -264,7 +264,7 @@ func getAuthenticator(ctx context.Context) (auth.Authenticator, error) {
 		authenticators = append(authenticators, auth.AuthenticateSingleUser(*serverUsername, randomPassword))
 	}
 
-	log(ctx).Noticef(`
+	log(ctx).Infof(`
 Server will allow connections from users whose accounts are stored in the repository.
 User accounts can be added using 'kopia server user add'.
 `)

cli/command_snapshot_create.go

@@ -271,7 +271,7 @@ func reportSnapshotStatus(ctx context.Context, manifest *snapshot.Manifest) erro
 
 	if ds := manifest.RootEntry.DirSummary; ds != nil {
 		if ds.IgnoredErrorCount > 0 {
-			log(ctx).Warningf("Ignored %v error(s) while snapshotting %v.", ds.IgnoredErrorCount, sourceInfo)
+			log(ctx).Errorf("Ignored %v error(s) while snapshotting %v.", ds.IgnoredErrorCount, sourceInfo)
 		}
 
 		if ds.FatalErrorCount > 0 {

cli/command_snapshot_estimate.go

@@ -39,7 +39,7 @@ func (ep *estimateProgress) Processing(ctx context.Context, dirname string) {
 
 func (ep *estimateProgress) Error(ctx context.Context, filename string, err error, isIgnored bool) {
 	if isIgnored {
-		log(ctx).Warningf("Ignored error in %v: %v", filename, err)
+		log(ctx).Errorf("Ignored error in %v: %v", filename, err)
 	} else {
 		log(ctx).Errorf("Error in %v: %v", filename, err)
 	}

cli/command_snapshot_list.go

@@ -146,7 +146,7 @@ func outputManifestGroups(ctx context.Context, rep repo.Repository, manifests []
 
 		pol, _, err := policy.GetEffectivePolicy(ctx, rep, src)
 		if err != nil {
-			log(ctx).Warningf("unable to determine effective policy for %v", src)
+			log(ctx).Errorf("unable to determine effective policy for %v", src)
 		} else {
 			pol.RetentionPolicy.ComputeRetentionReasons(snapshotGroup)
 		}
@@ -201,7 +201,7 @@ func outputManifestFromSingleSource(ctx context.Context, rep repo.Repository, ma
 		}
 
 		if _, ok := ent.(object.HasObjectID); !ok {
-			log(ctx).Warningf("entry does not have object ID: %v", ent, err)
+			log(ctx).Errorf("entry does not have object ID: %v", ent, err)
 			continue
 		}
 

cli/command_snapshot_migrate.go

@@ -54,7 +54,7 @@ func runMigrateCommand(ctx context.Context, destRepo repo.RepositoryWriter) erro
 		if !canceled {
 			canceled = true
 			for s, u := range activeUploaders {
-				log(ctx).Warningf("canceling active uploader for %v", s)
+				log(ctx).Infof("canceling active uploader for %v", s)
 				u.Cancel()
 			}
 		}
@@ -99,7 +99,7 @@ func runMigrateCommand(ctx context.Context, destRepo repo.RepositoryWriter) erro
 			}()
 
 			if err := migrateSingleSource(ctx, uploader, sourceRepo, destRepo, s); err != nil {
-				log(ctx).Warningf("unable to migrate source: %v", err)
+				log(ctx).Errorf("unable to migrate source: %v", err)
 			}
 		}(s)
 	}
@@ -148,7 +148,7 @@ func migrateAllPolicies(ctx context.Context, sourceRepo repo.Repository, destRep
 
 	for _, pol := range policies {
 		if err := migrateSinglePolicy(ctx, sourceRepo, destRepo, pol.Target()); err != nil {
-			log(ctx).Warningf("unable to migrate policy for %v: %v", pol.Target(), err)
+			log(ctx).Errorf("unable to migrate policy for %v: %v", pol.Target(), err)
 		}
 	}