-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a user configuration #84
Comments
Config story has been already described in detail for user and system scenarios covering L2 metadata. |
Proposing for 2.0 as discussed on today's hacking session. |
This is blocking #813. |
Is this still free? It can be nice to play around and try to implement: |
Yes, this is free. I expect the configuration format will need some discussion though. |
@therazix, regarding the implementation I would recommend to start with simplifying the following code: Lines 85 to 124 in e485608
Instead of the complex checking of the types and values, the code above should probably just do something like:
or maybe even something like this?
The rest would be handled by the |
@LecrisUT Cc ^^ would you have any tips WRT implementation of "containers with configuration"? In the light of current code in It would be the best if we could, cheaply and easily, if possible, land on a state where the user would be notified if Configuration is very similar to any other fmf tmt consumes - we can definitely use what we have now, and improve everything later, but, maybe we could use the configuration as a prototyping ground for the better state of the future. |
If I read this correctly the goal is for the user configurations to override the contents of the fmf file effectively? There is an ambiguity of how to order the preference between:
Maybe if we put some more restrictions that the user config can only affect leaf configurations the intent could be clearer. But then it can get quite weird figuring out which user config applies to the fmf tree of which project. Or are the fmf fields defined in the user configuration completely orthogonal, in which case what would the path signify? Are only a few fields or containers meant to be linked with configurations, maybe the class definition can be changed to a decorator instead of inheritance? About the container part, it would depend on the part above, but generally I was thinking that the containers are just the datastructures and basically as close to a json-schema as possible. The reading of the source: fmf tree, click arguments or configuration could be completely separate from this. How to unify the definitions within the Footnotes |
I see, the original story describing/brainstorming the possible features can be confusing. I think we would like to start small first. Without handling user versus system configuration and without interaction with test or plan metadata. We have the following tangible use case for the issue-tracker:
- type: jira
url: https://issues.redhat.com
tmt-web-url: http://tmt.testing-farm.io/
token: <secret> This is in no way related to affecting default values of tests or plans. It's a config to be used solely by the |
Seems we'll soon need a way how to store user configuration data. For example
tmt test export --nitrate
might need aurl
to the test case management system.Brainstorming first ideas here: What about storing data under
$HOME/.config/tmt
in the form of anfmf
tree? For the above-mentioned example we could have something like this:This would work naturaly / consistently with how the rest of data is handled in
tmt
.The text was updated successfully, but these errors were encountered: