Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full support for custom timeout in testcloud reboot #3305

Open
psss opened this issue Oct 18, 2024 · 1 comment
Open

Full support for custom timeout in testcloud reboot #3305

psss opened this issue Oct 18, 2024 · 1 comment
Labels
command | reboot Support for rebooting guests during `tmt run` and the `tmt-reboot` command plugin | testcloud The testcloud virtual provision plugin step | provision Stuff related to the provision step

Comments

@psss
Copy link
Collaborator

psss commented Oct 18, 2024

Currently setting the maximum time for a reboot in the testcloud plugin works only when a custom reboot command is used, for example like this:

tmt-reboot -t 60 -c reboot

It would be nice if we support timeout without the custom command as well:

tmt-reboot -t 60

The problem was revealed by the following test:

/tests/execute/reboot/shorten-timeout

Related code is here:

# Use custom reboot command if provided
if command:
return super().reboot(hard=hard, command=command)
if not self._instance:
raise tmt.utils.ProvisionError("No instance initialized.")
self._instance.reboot(soft=not hard)

Ideally testcloud would provide timeout parameter in instance.reboot() so that we can hand over the value.

@psss psss added step | provision Stuff related to the provision step plugin | testcloud The testcloud virtual provision plugin command | reboot Support for rebooting guests during `tmt run` and the `tmt-reboot` command labels Oct 18, 2024
@psss
Copy link
Collaborator Author

psss commented Oct 18, 2024

@frantisekz, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command | reboot Support for rebooting guests during `tmt run` and the `tmt-reboot` command plugin | testcloud The testcloud virtual provision plugin step | provision Stuff related to the provision step
Projects
None yet
Development

No branches or pull requests

1 participant