Skip to content

Commit bc3d892

Browse files
garymmfacebook-github-bot
authored andcommitted
README: Minor improvements (pytorch#56193)
Summary: * Visual studio versions: clarify and shorten. * Remove obsolete note about a bug that has been fixed. Pull Request resolved: pytorch#56193 Reviewed By: albanD Differential Revision: D27939766 Pulled By: ezyang fbshipit-source-id: e142ec04ba98d5468f28ddf2e8bba5d99d3cfc26
1 parent 21fd5f4 commit bc3d892

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

README.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -266,8 +266,8 @@ On Windows
266266

267267
Choose Correct Visual Studio Version.
268268

269-
Visual Studio upgrades are very often. Sometimes, there're regressions in some new versions.
270-
It'd best to use the same Visual Studio Version as [PyTorch CI's](https://github.com/pytorch/pytorch/blob/a1bd7918cc5a06cbef6c5178259bf0a7b5ab1ce3/.circleci/scripts/vs_install.ps1#L4).
269+
Sometimes there are regressions in new versions of Visual Studio, so
270+
it's best to use the same Visual Studio Version as [PyTorch CI's](https://github.com/pytorch/pytorch/blob/a1bd7918cc5a06cbef6c5178259bf0a7b5ab1ce3/.circleci/scripts/vs_install.ps1#L4).
271271
You can use Visual Studio Enterprise, Professional or Community though PyTorch CI uses Visual Studio BuildTools.
272272

273273
Build with CPU
@@ -293,8 +293,6 @@ CUDA, MSVC, and PyTorch versions are interdependent; please install matching ver
293293
| 10.2 | Visual Studio 2019 (16.X) (`_MSC_VER` < 1930) | 1.5.0 ~ 1.7.0 |
294294
| 11.0 | Visual Studio 2019 (16.X) (`_MSC_VER` < 1930) | 1.7.0 |
295295

296-
Note: There's a [compilation issue](https://github.com/oneapi-src/oneDNN/issues/812) in several Visual Studio 2019 versions since 16.7.1, so please make sure your Visual Studio 2019 version is not in 16.7.1 ~ 16.7.5
297-
298296
Additional libraries such as
299297
[Magma](https://developer.nvidia.com/magma), [oneDNN, a.k.a MKLDNN or DNNL](https://github.com/oneapi-src/oneDNN), and [Sccache](https://github.com/mozilla/sccache) are often needed. Please refer to the [installation-helper](https://github.com/pytorch/pytorch/tree/master/.jenkins/pytorch/win-test-helpers/installation-helpers) to install them.
300298

0 commit comments

Comments
 (0)