Un-ignore F403 in .flake8 (pytorch#55838)

Summary:
Generally wildcard imports are bad for the reasons described here: https://www.flake8rules.com/rules/F403.html

This PR replaces wildcard imports with an explicit list of imported items where possible, and adds a `# noqa: F403` comment in the other cases (mostly re-exports in `__init__.py` files).

This is a prerequisite for pytorch#55816, because currently [`tools/codegen/dest/register_dispatch_key.py` simply fails if you sort its imports](https://github.com/pytorch/pytorch/actions/runs/742505908).

Pull Request resolved: pytorch#55838

Test Plan: CI. You can also run `flake8` locally.

Reviewed By: jbschlosser

Differential Revision: D27724232

Pulled By: samestep

fbshipit-source-id: 269fb09cb4168f8a51fd65bfaacc6cda7fb87c34

Author: samestep

.flake8

@@ -4,7 +4,7 @@ max-line-length = 120
 # C408 ignored because we like the dict keyword argument syntax
 # E501 is not flexible enough, we're using B950 instead
 ignore =
-    E203,E305,E402,E501,E721,E741,F403,F405,F821,F841,F999,W503,W504,C408,E302,W291,E303,
+    E203,E305,E402,E501,E721,E741,F405,F821,F841,F999,W503,W504,C408,E302,W291,E303,
     # shebang has extra meaning in fbcode lints, so I think it's not worth trying
     # to line this up with executable bit
     EXE001,

benchmarks/fastrnns/__init__.py

@@ -1,5 +1,5 @@
-from .cells import *
-from .factory import *
+from .cells import *  # noqa: F403
+from .factory import *  # noqa: F403
 
 # (output, next_state) = cell(input, state)
 seqLength = 100

benchmarks/fastrnns/runner.py

@@ -3,7 +3,12 @@
 import torch
 import torchvision.models as cnn
 
-from .factory import *
+from .factory import (dropoutlstm_creator, imagenet_cnn_creator,
+                      layernorm_pytorch_lstm_creator, lnlstm_creator,
+                      lstm_creator, lstm_multilayer_creator,
+                      lstm_premul_bias_creator, lstm_premul_creator,
+                      lstm_simple_creator, pytorch_lstm_creator,
+                      varlen_lstm_creator, varlen_pytorch_lstm_creator)
 
 
 class DisableCuDNN():

test/jit/test_hooks.py

@@ -1,9 +1,24 @@
 import os
 import sys
 import unittest
+from typing import Tuple
 
 import torch
-from jit.test_hooks_modules import *
+from jit.test_hooks_modules import (
+    ModuleDirectFowardSubmodCall, ModuleForwardSingleInput,
+    ModuleForwardTupleInput, create_forward_tuple_input,
+    create_module_forward_multiple_inputs, create_module_forward_single_input,
+    create_module_hook_return_nothing,
+    create_module_multiple_hooks_multiple_inputs,
+    create_module_multiple_hooks_single_input, create_module_no_forward_input,
+    create_module_same_hook_repeated, create_submodule_forward_multiple_inputs,
+    create_submodule_forward_single_input,
+    create_submodule_forward_single_input_return_not_tupled,
+    create_submodule_hook_return_nothing,
+    create_submodule_multiple_hooks_multiple_inputs,
+    create_submodule_multiple_hooks_single_input,
+    create_submodule_no_forward_input, create_submodule_same_hook_repeated,
+    create_submodule_to_call_directly_with_hooks)
 
 # Make the helper files in test/ importable
 pytorch_test_dir = os.path.dirname(os.path.dirname(os.path.realpath(__file__)))

test/jit_hooks/model.py

@@ -6,7 +6,18 @@
 # grab modules from test_jit_hooks.cpp
 pytorch_test_dir = os.path.dirname(os.path.dirname(os.path.realpath(__file__)))
 sys.path.append(pytorch_test_dir)
-from jit.test_hooks_modules import *
+from jit.test_hooks_modules import (
+    create_forward_tuple_input, create_module_forward_multiple_inputs,
+    create_module_forward_single_input, create_module_hook_return_nothing,
+    create_module_multiple_hooks_multiple_inputs,
+    create_module_multiple_hooks_single_input, create_module_no_forward_input,
+    create_module_same_hook_repeated, create_submodule_forward_multiple_inputs,
+    create_submodule_forward_single_input,
+    create_submodule_hook_return_nothing,
+    create_submodule_multiple_hooks_multiple_inputs,
+    create_submodule_multiple_hooks_single_input,
+    create_submodule_same_hook_repeated,
+    create_submodule_to_call_directly_with_hooks)
 
 # Create saved modules for JIT forward hooks and pre-hooks
 def main():

test/mobile/test_lite_script_module.py

@@ -1,8 +1,8 @@
 import torch
 import torch.utils.bundled_inputs
-from torch.utils.mobile_optimizer import *
+from torch.utils.mobile_optimizer import optimize_for_mobile
 import io
-from typing import NamedTuple
+from typing import Dict, List, NamedTuple
 from collections import namedtuple
 
 from torch.jit.mobile import _load_for_lite_interpreter, _export_operator_list

test/onnx/model_defs/__init__.py

@@ -1,4 +1,4 @@
-from .squeezenet import *
-from .super_resolution import *
-from .op_test import *
-from .srresnet import *
+from .squeezenet import *  # noqa: F403
+from .super_resolution import *  # noqa: F403
+from .op_test import *  # noqa: F403
+from .srresnet import *  # noqa: F403

test/onnx/test_pytorch_common.py

@@ -8,7 +8,7 @@
 pytorch_test_dir = os.path.dirname(os.path.dirname(os.path.realpath(__file__)))
 sys.path.insert(-1, pytorch_test_dir)
 
-from torch.testing._internal.common_utils import *  # noqa: F401
+from torch.testing._internal.common_utils import *  # noqa: F401,F403
 
 torch.set_default_tensor_type('torch.FloatTensor')
 

test/test_jit_fuser_legacy.py

@@ -1,6 +1,6 @@
 import sys
 sys.argv.append("--jit_executor=legacy")
-from test_jit_fuser import *
+from test_jit_fuser import *  # noqa: F403
 
 if __name__ == '__main__':
     run_tests()

test/test_jit_legacy.py

@@ -1,6 +1,6 @@
 import sys
 sys.argv.append("--jit_executor=legacy")
-from test_jit import *
+from test_jit import *  # noqa: F403
 
 if __name__ == '__main__':
     run_tests()