Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning alert when upgrading to angular 10 #60

Open
Slash7GNR opened this issue Jul 13, 2020 · 7 comments
Open

Warning alert when upgrading to angular 10 #60

Slash7GNR opened this issue Jul 13, 2020 · 7 comments

Comments

@Slash7GNR
Copy link

Hi,
When running ng build / serve, I'm receiving the following warning:

WARNING in /Users/inno/Desktop/Kobura/kob-ui/node_modules/@techiediaries/ngx-qrcode/__ivy_ngcc__/fesm2015/ngx-qrcode2.js depends on 'qrcode'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

There is a way to suppress the error by adding 'qrcode' to 'allowedCommonJsDependencies' in the angular.json file.
Is there any way you can solve this warning without suppressing it ?

Best regards,
Nadav

@rafa-suagu
Copy link
Collaborator

Thanks for your comments @Slash7GNR .

We will work to make this library fully compatible with Angular 10 the next weeks. Stay tuned.

@beeing
Copy link

beeing commented Oct 8, 2020

Hi, any updates on this?

Is this a simple fix or need some kind of restructuring?

@Maik-Robin
Copy link

Hi, @rafa-as this WARNING Message is still apperaing. We'd like to use your component, but we do have some concerns regarding this Message. Can you provide some more information and has Angular 10 full supported yet?

@pauloneill
Copy link

This is still happening for me in Angular 10 - any update please?

@morgan-wild
Copy link

Up! Same issue here :)

@beeing
Copy link

beeing commented Aug 18, 2021

This is also based on soldair/node-qrcode#241 which is not merged.

Also looks like the repo is not really maintained. Perhaps can create fork to test this out.

@mw108
Copy link

mw108 commented Jun 15, 2023

2023 and the warning still appears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants