Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functions (predicate/computed field) need to be consolidated and modularized #44

Open
rsinger opened this issue Mar 24, 2015 · 0 comments

Comments

@rsinger
Copy link
Member

rsinger commented Mar 24, 2015

Currently, we have functions that can be embedded in predicates ("join", "lowercase", "date") and functions that can be used in computed fields (#40) ("conditional", "replace", "arithmetic") as well as the "link" function.

These should be consolidated, so they can be chained, but they should also be removed from MongoTripodTables, so they can be used elsewhere (and be more easily extended, tested, etc.), possibly/probably instantiated via a factory pattern.

The issue currently is how to reconcile the functionality between the two: predicate modifiers are working on the graph data, where the computed field functions expect tabular data (and they have different expectations on how they get that data and what's available at the point in time).

While we're at it, we should deprecate the 'predicate' modifiers being in a predicate property, since the whole semantics of that seem a little awkward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant